Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default pagination params might cause old alerts to create notifications #2

Open
krystianity opened this issue Jan 2, 2023 · 0 comments
Open

Default pagination params might cause old alerts to create notifications #2

krystianity opened this issue Jan 2, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@krystianity
Copy link
Member

As default pagination params are used, old alerts might cause notifications when the total alerts exceed the default params e.g. > 50 alerts.

Quick fix: Dont create notifications for new alerts in status ACCEPTED
Better fix: Initially page through all pending alerts when extension is initialized
@krystianity krystianity added the enhancement New feature or request label Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@krystianity