From 5a0b9bcba378328e147ed295115a9a6979a14adf Mon Sep 17 00:00:00 2001 From: Angel de la Torre Date: Mon, 11 Dec 2023 11:12:43 -0800 Subject: [PATCH] gh actions: apply masking option to ecr login There is a warning about the 'mask-password' option for the "amazon-ecr-login" action. If ran in debug mode, the password will be outputted. By default this option is not enabled as the expectation is to run the service after the deployment but as a secondary job. As such the password cannot be masked as it is needed to run the service. https://github.com/aws-actions/amazon-ecr-login#run-an-image-as-a-service However, this is not the workflow we have set up, therefore we need to enable the option to mask the password. --- .github/workflows/build-image.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/build-image.yml b/.github/workflows/build-image.yml index 179079a..4ddad9f 100644 --- a/.github/workflows/build-image.yml +++ b/.github/workflows/build-image.yml @@ -25,6 +25,8 @@ jobs: - name: Login to Amazon ECR id: login-ecr uses: aws-actions/amazon-ecr-login@v1 + with: + mask-password: true - name: Build, Tag, and Push Image to Amazon ECR env: