Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add CI-specific view #340

Open
danielbeardsley opened this issue Oct 26, 2022 · 10 comments
Open

CI: Add CI-specific view #340

danielbeardsley opened this issue Oct 26, 2022 · 10 comments
Labels
QAE Quality Assurance Engineering

Comments

@danielbeardsley
Copy link
Member

danielbeardsley commented Oct 26, 2022

Problem

I often want to see the ~10 or so recent runs of a certain CI status to see if problems are isolated to a particular pull, or if it's a system-wide failure

Potential Solution

A view that shows a table of CI runs where the rows are pulls and the columns are CI statuses, click the column headers to sort the pulls by when that CI status was finished (or started?)

Another option would be to only show one status at a time and have the rows be pulls and the columns be:

  • Pull title (links to pull)
  • Branch name
  • CI time
  • Status (Links to log)

This seems a bit more focused

@danielbeardsley
Copy link
Member Author

☝️ CC @iFixit/qae

@ardelato ardelato added the QAE Quality Assurance Engineering label Oct 26, 2022
@ardelato
Copy link
Contributor

@danielbeardsley do you want to see this implemented particularly on Pulldasher or do you want to be able to find out that information in some way?

@mlahargou
Copy link
Member

Is this what you're looking for?

https://metabase.ifixit.com/dashboard/47-ci-status

It's broken since we stopped writing to ifixit I believe.

@danielbeardsley
Copy link
Member Author

do you want to see this implemented particularly on Pulldasher

Yeah. We have all the data right there in the browser in the pull objects and it's live / kept up to date.

@danielbeardsley
Copy link
Member Author

Yes, this, but allow choosing a particular CI status (one of the 19!)
image

I'd imagine adding a link on each row here that would open the CI view with all the recent runs of that CI job:
image

@danielbeardsley
Copy link
Member Author

FYI, we have all the merged pulls from the last two weeks on the client side: https://github.com/iFixit/pulldasher/blob/master/app.js#L50-L58

So all the data is there.

@mlahargou
Copy link
Member

Cool! Sounds good to me 👍

@mlahargou
Copy link
Member

FYI we already have a grafana chart with the phpunit data (unit, integration, api, chrome):
image

https://dashboards.cominor.com/d/ATRAxhR4k/ci-status?orgId=1

@mlahargou
Copy link
Member

QAE doesn't plan on doing this any time soon. Pulling it off of our backlog.

@danielbeardsley
Copy link
Member Author

I made a proof-of-concept in a branch:
https://github.com/iFixit/pulldasher/compare/ci-dashboard-proof-of-concept

But then I remembered that we only include CI runs / checks for the most recent commit of each pull. This definitely limits its usefulness because it doesn't represent the collection of recent runs but the collection of runs on recent commits.

It may still help answer the question: "Of the CI blocked pulls, which statuses are causing the blocks"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QAE Quality Assurance Engineering
Projects
None yet
Development

No branches or pull requests

3 participants