Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overriding files is unstable #24

Open
ultramaryna opened this issue May 5, 2022 · 1 comment
Open

Overriding files is unstable #24

ultramaryna opened this issue May 5, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@ultramaryna
Copy link

Overriding files from the original React Checkout is unstable. When you are running the app in developer mode (npm run start), overriding (as described here: https://github.com/hyva-themes/magento2-checkout-example#copying-react-components) doesn't always work. Restarting the app doesn't help. You need to make a production build to see your changes.

It's not always the case and it's been hard to track when exactly it happens. In our team of three, it happened for some of us more often than for the others. We use Mac, Docker and node 16.

Discussion from Hyva slack: https://hyva-themes.slack.com/archives/C01C5DBHL64/p1650025097720269

@rajeev-k-tomy
Copy link
Collaborator

A work around I found for this problem is given below.

  1. You already started the app in development mode npm start.
  2. Now, a situation came where you want to add a new file (which exists already in the original module) into example module. You are adding it.
  3. Seems no changes on the frontend.
  4. Kill the process. Cntrl + C.
  5. Remove cache directory directly rm -rf node_modules/.cache.
  6. Start the app again npm start
  7. You should see the new file is picked up without problems.

@rajeev-k-tomy rajeev-k-tomy added the bug Something isn't working label May 17, 2022
@wigman wigman closed this as completed Oct 4, 2022
@rajeev-k-tomy rajeev-k-tomy reopened this Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants