-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hdrop: 0.1.3 -> 0.2.1, Update readme #73
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I think it would be better to have all the documentation inside a manpage.
Ok, i added it and reduced the help text. I have a question: On
On
What's the difference / which one is better and why? |
I think the one in Nixpkgs is idiomatic, as |
I see, thanks. Is |
Ok, looks good. Only one more thing, can you rename the commits in the style |
Please squash them, I'll do it correctly the next time. If i now start doing force pushes or something like that i'll screw it up because i'm just learning Github etc. |
I've rebased the commits and squashed a few. Looks good? |
To be honest, i don't understand that part yet. But if you're satisfied, then so am i ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, LGTM. Thanks :)
No description provided.