Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shellevents: add windowtitlev2 event #121

Merged
merged 2 commits into from
Oct 18, 2024
Merged

shellevents: add windowtitlev2 event #121

merged 2 commits into from
Oct 18, 2024

Conversation

andresilva
Copy link
Contributor

@andresilva andresilva commented Oct 17, 2024 •
edited
Loading

Description of changes

Things done

  • For new programs

    • Add the program to the README table, with yourself as the
      maintainer
    • Add a README for the program itself
    • Add Makefile (and Nix derivation optionally, otherwise @fufexan will do
      it)
    • If the program is a script, add it to the
      CI checks matrix

  • For changes

@fufexan
Copy link
Member

fufexan commented Oct 17, 2024

@trippwill

@trippwill
Copy link
Contributor

@fufexan looks good to me.

I'm not currently an active user of Hyprland, and this contrib seems to be getting some use. Could you find a new, more active, maintaner?

@fufexan
Copy link
Member

fufexan commented Oct 17, 2024

Sure, I'll open an issue requesting a maintainer.

fufexan
fufexan reviewed Oct 17, 2024
View reviewed changes
Copy link
Member

@fufexan fufexan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also mention this addition in the changelog?

@andresilva
Copy link
Contributor Author

@fufexan updated the changelog

fufexan
fufexan approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@fufexan fufexan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fufexan fufexan merged commit d72bc8b into hyprwm:main Oct 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fufexan fufexan fufexan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andresilva @fufexan @trippwill