replacing existing fullscreen #8566
Conversation
this allows replacement of fullscreen window(i.e. fullscreening another window when one is already fullscreened on the workspace) this is used when a floating window that is spawned on top of a fullscreen wanted to be fullscreened
|
should this even be gated? |
|
i mean, someone didn't implement this at the first place for a reason, but I'll remove it |
littleblack111
changed the title
binds:allow_replace_fullscreen
|
there is an issue now, if you have a fullscreen window and replace it with a floating pinned window, that originally fullscreened window won't restore back to fullscreen after un-fullscreening the floating pinned window. don't know how to fix |
|
try removing the pin status? unsure |
|
ahh, no one prob gonna notice anyway, how abt merge it for now and fix it if it turned into a more severe issue also rn theres a issue with pin that can be fixed with this(if u try to fullscreen the pinned window when another window is fullscreened, it'd mess up that var that stores the pin state). |
|
I don't think introducing issues on purpose is a good idea |
|
i mean i think this should be a intended behavior, kind of like how draging a fullscreen window will turn them into tiled or floating but not return to fullscreen state after |
|
would u want me to work on it? |
|
ah yeah sorry so many notifications, feel free |
|
re-reading this:
I don't think that's a problem. I am fine with this as-is |
|
sorry for my previous comments idk I may have been braindead. Let me know if you are fine with this as is |
|
ya sure, feel free to merge |
Describe your PR, what does it fix/add?
this allows replacement of fullscreen window(i.e. fullscreening another window when one is already fullscreened on the workspace)
this is used when a floating window that is spawned on top of a fullscreen wanted to be fullscreened
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
no
Is it ready for merging, or does it need work?
ready