Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [compositor, misc] ability to select previous workspace per monitor #6598

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

Truenya
Copy link
Contributor

@Truenya Truenya commented Jun 19, 2024

Describe your PR, what does it fix/add?

added previous_per_monitor parameter that selects the previously focused workspace on the currently focused monitor
#6545

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

no

Is it ready for merging, or does it need work?

ready

src/macros.hpp Outdated Show resolved Hide resolved
@Truenya Truenya force-pushed the main branch 2 times, most recently from 0e4a063 to 91574ea Compare June 20, 2024 09:42
vaxerski
vaxerski previously approved these changes Jun 20, 2024
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, needs a wiki mr

@vaxerski
Copy link
Member

and a clang-format

@Truenya
Copy link
Contributor Author

Truenya commented Jun 21, 2024

about clang format, I'm using version 18.1.6
used such script for formatting

#!/bin/bash
for file in $(git diff --name-only); do
	echo "$file formatted"
	clang-format --style=file -i $file
done

@vaxerski
Copy link
Member

clang-format -i src/**/*{cpp,hpp} works for me.
image

Just remove those changes

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@vaxerski vaxerski merged commit 7f09646 into hyprwm:main Jun 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants