-
-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xdg-shell: Continue transform of popup until size fits #6521
Conversation
But why would they put slide as 1 and 2... ffs |
There we go, proper order. It just didn't apply the flip because it tested if the flip change by itself would fix the position. Hence it continued and eventually failed to position the popup. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gangsta, thanks
Describe your PR, what does it fix/add?
This is before this change:
nautilus.mp4
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
There is an issue with opening the popup at the exact point where it should flip upwards -> it pops up, and then flips (this also exists in main)
Is it ready for merging, or does it need work?
Should be ready other than what's above