Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hyprctl: add --quiet flag #6380

Merged
merged 1 commit into from
Jun 9, 2024
Merged

Conversation

diniamo
Copy link
Contributor

@diniamo diniamo commented Jun 9, 2024

Describe your PR, what does it fix/add?

Adds a --quiet flag to hyprctl that supresses its output.

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

Might want to use setstate(failbit) instead of rdbuf(nullptr), I'm not sure.

Is it ready for merging, or does it need work?

It's ready.

hyprctl/main.cpp Outdated Show resolved Hide resolved
@diniamo diniamo force-pushed the hyprctl-quiet-flag branch from 5fe2e73 to fd4ddca Compare June 9, 2024 09:30
@diniamo
Copy link
Contributor Author

diniamo commented Jun 9, 2024

How is this?

Note:

  • I left normal cout for usage prints, should those also be included?
  • Removed the endl print at the end, since I highly doubt it's necessary, and is also annoying

hyprctl/main.cpp Outdated Show resolved Hide resolved
hyprctl/main.cpp Outdated Show resolved Hide resolved
hyprctl/main.cpp Show resolved Hide resolved
@diniamo diniamo force-pushed the hyprctl-quiet-flag branch from fd4ddca to f07ead6 Compare June 9, 2024 17:52
@diniamo
Copy link
Contributor Author

diniamo commented Jun 9, 2024

That should be all.

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks!

@vaxerski vaxerski merged commit 121c6ac into hyprwm:main Jun 9, 2024
11 checks passed
@diniamo diniamo deleted the hyprctl-quiet-flag branch August 27, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants