-
-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1px layer-surfaces on top and left sides of the screen can not be entered #6170
Comments
can you test on git |
after testing on git:
I have not personally tested on Hyprland 0.39.1 but according to this comment , this was not a problem in 0.39.1 |
For me in the git version, cursor can't escape when using top or left positions, but returning to the hyprland surface works without any problems, just like in 0.39.1 UPD: When saying about returning to the surface, I'm referring to the bottom and right positions, I haven't tested the top and left positions because the cursor can't leave them. |
Latest git (93fea89) does not crash but surfaces placed top or left can not be entered (arguably a separate issue). v0.40.0:
|
Some more information: export LM_DEBUG_LAYER_SHELL=1
lan-mouse --test-capture should show 1px wide green windows on all four sides. (this works on sway and KDE!) on Hyprland none of the surfaces are shown. bottom and right positions generate enter events correctly, top and left positions for the layer-surface never generate an enter event diff --git a/src/capture/wayland.rs b/src/capture/wayland.rs
index 9f2b82c..1aac930 100644
--- a/src/capture/wayland.rs
+++ b/src/capture/wayland.rs
@@ -146,8 +146,8 @@ impl Window {
let g = &state.g;
let (width, height) = match pos {
- Position::Left | Position::Right => (1, size.1 as u32),
- Position::Top | Position::Bottom => (size.0 as u32, 1),
+ Position::Left | Position::Right => (2, size.1 as u32),
+ Position::Top | Position::Bottom => (size.0 as u32, 2),
};
let mut file = tempfile::tempfile().unwrap();
draw(&mut file, (width, height)); Increasing the width of the surface by 1px to 2px, fixes both issues. |
@vaxerski could you rename this issue to something like I could also open a new issue, as the original problem here is fixed. And to be more specific: I'm not getting an "Enter" event on 1px surfaces top and left side of the screen. |
I think we should continue here since this is related, It would be better if all the issues regarding this are wrapped in a single issue for future references? If not, I can close the issue , for now I have renamed the issue as the previous title was no longer relevant. |
check out #6027, probably changes that behaviour |
Can confirm, #6027 fixes this |
Thanks Everyone !! |
Hyprland Version
System/Version info
Bug or Regression?
Regression
Description
When using lan-mouse
during input capture if cursor is taken to the edge of the screen hyprland crashes
How to reproduce
Crash reports, logs, images, videos
hyprlandCrashReport621782.txt
The text was updated successfully, but these errors were encountered: