fix bug in previous doLater cleanup

hyprwm · Dec 3, 2024 · 6a8c756 · 6a8c756
1 parent 9218689
commit 6a8c756
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/src/protocols/XDGShell.cpp b/src/protocols/XDGShell.cpp
@@ -487,10 +487,14 @@ uint32_t CXDGSurfaceResource::scheduleConfigure() {
     if (configureScheduled)
         return scheduledSerial;
 
-    scheduledSerial = wl_display_next_serial(g_pCompositor->m_sWLDisplay);
-
+    scheduledSerial    = wl_display_next_serial(g_pCompositor->m_sWLDisplay);
     configureScheduled = true;
-    g_pEventLoopManager->doLater([this]() { configure(); });
+
+    // sometimes `this` is unreferencable due to timing, so copy self WP to ensure object is alive
+    g_pEventLoopManager->doLater([pSelf = self] {
+        if (!pSelf.expired())
+            pSelf->configure();
+    });
 
     return scheduledSerial;
 }