-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent responses on inbox methods #38
Labels
enhancement
New feature or request
Comments
github-project-automation
bot
moved this to Needs triage
in Distributed Press Organizing
Feb 5, 2024
sutty-coop
added
question
Further information is requested
and removed
enhancement
New feature or request
labels
Feb 6, 2024
4 tasks
Is this question for @RangerMauve or for @akhileshthite ? |
unsure! any of both i guess |
Personally I think I'd prefer the text/plain responses instead of the json one. |
I got an |
fauno
added
enhancement
New feature or request
and removed
question
Further information is requested
labels
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While working on the Inbox client I've noticed this:
{"statusCode"=>400, "error"=>"Unauthorized", "message"=>"Must specify 'actor' URL in activity" }
{"statusCode"=>403, "error"=>"Forbidden", "message"=>"Submitted activity must be from signed actor [...]"}
{ "message": "ok" }
https://www.w3.org/TR/activitypub/ doesn't say much about status codes, I see Mastodon just replies 202 Accepted2 for every case with an empty response while receiving an activity.
Could we make all errors return a JSON object and AP content type? I'd change the three status codes for remote instances to 202, which doesn't make any promise about the request, just in case someone expects it to be exactly this number.
Footnotes
I'll need time to produce all errors, so I read
inbox.ts
instead. The default response type for this request is set to string. ↩Wikipedia: The request has been accepted for processing, but the processing has not been completed. The request might or might not be eventually acted upon, and may be disallowed when processing occurs. ↩
The text was updated successfully, but these errors were encountered: