Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CreateCsvDownloaderService #2367

Merged
merged 15 commits into from
Sep 15, 2023
Merged

feat: CreateCsvDownloaderService #2367

merged 15 commits into from
Sep 15, 2023

Conversation

palbizu
Copy link
Contributor

@palbizu palbizu commented Aug 25, 2023

Description

Adding Create CSV Downloader Service

Testing

Locally tested

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@palbizu palbizu requested a review from a team as a code owner August 25, 2023 02:27
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #2367 (d804365) into main (f4ae953) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2367      +/-   ##
==========================================
+ Coverage   82.93%   82.95%   +0.02%     
==========================================
  Files         920      921       +1     
  Lines       20493    20522      +29     
  Branches     3223     3227       +4     
==========================================
+ Hits        16995    17024      +29     
  Misses       3376     3376              
  Partials      122      122              
Files Changed Coverage Δ
projects/components/src/table/table.component.ts 78.18% <100.00%> (+0.09%) ⬆️
projects/observability/src/public-api.ts 100.00% <100.00%> (ø)
...d/widgets/table/table-widget-renderer.component.ts 46.61% <100.00%> (+0.92%) ⬆️
...global-csv-download/global-csv-download.service.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions

This comment has been minimized.

@itssharmasandeep
Copy link
Contributor

What is the actual use case of this? Why can't we directly use FileDownloadService and why do we need registration?

@palbizu
Copy link
Contributor Author

palbizu commented Aug 25, 2023

What is the actual use case of this? Why can't we directly use FileDownloadService and why do we need registration?

Provide a way to share multi-level data through different components, applying it for tables, dashboard and generic components

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@palbizu palbizu requested a review from arjunlalb August 28, 2023 14:14
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@palbizu palbizu merged commit 17f4dca into main Sep 15, 2023
@palbizu palbizu deleted the CreateCsvDownloaderService branch September 15, 2023 15:26
@github-actions
Copy link

Unit Test Results

       4 files  ±0     310 suites  +1   41m 27s ⏱️ - 5m 44s
1 123 tests +2  1 123 ✔️ +2  0 💤 ±0  0 ❌ ±0 
1 133 runs  +2  1 133 ✔️ +2  0 💤 ±0  0 ❌ ±0 

Results for commit 17f4dca. ± Comparison against base commit f4ae953.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants