Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the GetAllConfigsRequest to accept multiple resource_names #13

Open
avinashkolluru opened this issue Jan 20, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@avinashkolluru
Copy link

Current schema:

message GetAllConfigsRequest {
  // required - name of the resource associated with the config
  string resource_name = 1;

  // required - namespace with which the config resource is associated
  string resource_namespace = 2;
}

This should be enhanced to something like the below:

message GetAllConfigsRequest {
  repeated ResourceIdentity = 1;
}

message ResourceIdentity {
 // required - name of the resource associated with the config
  string resource_name = 1;

  // required - namespace with which the config resource is associated
  string resource_namespace = 2;
}
@avinashkolluru avinashkolluru added the enhancement New feature or request label Jan 20, 2021
@aaron-steinfeld
Copy link
Contributor

My preference on this feature would be to add filter support. Something like:

message GetAllConfigsRequest {
  string resource_name = 1;
  string resource_namespace = 2;
  ConfigFilter filter = 3;
}

message ConfigFilter {
   repeated string context = 1;
  // Can add other filter support as needed
}

The reasoning here:

  1. Backwards compatibility
  2. More extensible
  3. Keeps the same expectations on the query side around how a config is structured - that is a name should represent a type of config. That is, the proposed api can return values of different shapes because I can ask for multiple different resources across multiple namespaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants