Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does PATH$path_link_vertex need an order column? #135

Open
krlmlr opened this issue Dec 14, 2020 · 2 comments
Open

Does PATH$path_link_vertex need an order column? #135

krlmlr opened this issue Dec 14, 2020 · 2 comments

Comments

@krlmlr
Copy link

krlmlr commented Dec 14, 2020

Otherwise the vertex order is determined only by the order of rows in the data frame, and would be lost if copying to a database.

@mdsumner
Copy link
Member

yes for sure ... I consider this all up-for-grabs but there's been very little interest or feedback at all - in practice I've found I use PATH0() much more readily (long character keys are too heavy), but the same issue applies in the nested data frames on PATH0()$object$path_.

I didn't really know how to go about any of this, I originally thought there'd be some kind of tricks available but it seems you just have to trade compactness for flexibility as required, and the tools in silicate reflect the different intermediate forms I tend to use as well as some loftier ideas that don't necessarily need to exist.

Thanks!

@mdsumner
Copy link
Member

I'd be inclined to write some kind of extension or replace to PATH0() that assumes the use of a database back-end for the vertex indices than modify silicate itself (ala #134 ) and also takes into account the use of {geometries} and/or {interleave} for the conversion/s: dcooley/geometries#4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants