Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration tests #1958

Merged
merged 15 commits into from
Sep 20, 2023
Merged

Fix integration tests #1958

merged 15 commits into from
Sep 20, 2023

Conversation

NickSneo
Copy link
Contributor

@NickSneo NickSneo commented Sep 3, 2023

What does this PR do?

Fix integration tests

Where should the reviewer start?

review all files except in folder integration-tests/src/test/resources/quorum-test-network

Why is it needed?

Currently many test were disabled as they were failing and many deprecated tests were included which are needed to be removed

Signed-off-by: Nischal Sharma <[email protected]>
@NickSneo NickSneo changed the title Fix integration tests [Draft] Fix integration tests Sep 3, 2023
@codecov
Copy link

codecov bot commented Sep 3, 2023

Codecov Report

Merging #1958 (b3a7e93) into master (f6a2aed) will increase coverage by 0.21%.
Report is 12 commits behind head on master.
The diff coverage is n/a.

❗ Current head b3a7e93 differs from pull request most recent head f2e1c87. Consider uploading reports for the commit f2e1c87 to get more accurate results

@@             Coverage Diff              @@
##             master    #1958      +/-   ##
============================================
+ Coverage     68.15%   68.36%   +0.21%     
- Complexity     2986     2993       +7     
============================================
  Files           488      488              
  Lines         12501    12510       +9     
  Branches       1627     1631       +4     
============================================
+ Hits           8520     8553      +33     
+ Misses         3507     3482      -25     
- Partials        474      475       +1     
Files Changed Coverage Δ
.../src/main/java/org/web3j/protocol/admin/Admin.java 50.00% <ø> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@NickSneo NickSneo changed the title [Draft] Fix integration tests Fix integration tests Sep 7, 2023
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Copy link
Contributor

@gtebrean gtebrean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The config files were uploaded from the local network generated files?

@NickSneo
Copy link
Contributor Author

The config files were uploaded from the local network generated files?

These configs are taken directly from Besu-dev-quickstart repo and as generated by npx besu-dev-quickstart script

Signed-off-by: Nischal Sharma <[email protected]>
@gtebrean gtebrean merged commit ac0618c into master Sep 20, 2023
4 checks passed
@NickSneo NickSneo deleted the nicks/integrationTests-fix branch September 20, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants