-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix integration tests #1958
Fix integration tests #1958
Conversation
Signed-off-by: Nischal Sharma <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1958 +/- ##
============================================
+ Coverage 68.15% 68.36% +0.21%
- Complexity 2986 2993 +7
============================================
Files 488 488
Lines 12501 12510 +9
Branches 1627 1631 +4
============================================
+ Hits 8520 8553 +33
+ Misses 3507 3482 -25
- Partials 474 475 +1
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The config files were uploaded from the local network generated files?
...ration-tests/src/test/java/org/web3j/protocol/besu/BesuPrivacyQuickstartIntegrationTest.java
Show resolved
Hide resolved
These configs are taken directly from Besu-dev-quickstart repo and as generated by npx besu-dev-quickstart script |
Signed-off-by: Nischal Sharma <[email protected]>
What does this PR do?
Fix integration tests
Where should the reviewer start?
review all files except in folder
integration-tests/src/test/resources/quorum-test-network
Why is it needed?
Currently many test were disabled as they were failing and many deprecated tests were included which are needed to be removed