Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CipherException from org.web3j.crypto to org.web3j.crypto.exception #1945

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

JayMaro
Copy link
Contributor

@JayMaro JayMaro commented Aug 16, 2023

What does this PR do?

Move CipherException from org.web3j.crypto to org.web3j.crypto.exception

Where should the reviewer start?

org.web3j.crypto.exception

Why is it needed?

There is exception package in org.web3j.crypto but CipherException is not in exception package.

@JayMaro JayMaro requested a review from conor10 as a code owner August 16, 2023 14:35
@JayMaro
Copy link
Contributor Author

JayMaro commented Aug 22, 2023

Sorry i didn't know about format violation. I fixed it. Thank you.

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #1945 (02f2aca) into master (aaebd8e) will increase coverage by 0.30%.
Report is 711 commits behind head on master.
The diff coverage is 75.96%.

@@             Coverage Diff              @@
##             master    #1945      +/-   ##
============================================
+ Coverage     67.82%   68.13%   +0.30%     
- Complexity     2155     2985     +830     
============================================
  Files           414      488      +74     
  Lines          8960    12501    +3541     
  Branches       1191     1627     +436     
============================================
+ Hits           6077     8517    +2440     
- Misses         2588     3509     +921     
- Partials        295      475     +180     
Files Changed Coverage Δ
...c/main/java/org/web3j/abi/datatypes/BytesType.java 40.00% <0.00%> (-7.06%) ⬇️
.../main/java/org/web3j/abi/datatypes/Utf8String.java 47.05% <0.00%> (-10.09%) ⬇️
...j/abi/datatypes/ens/EnsCallBackFunctionParams.java 0.00% <0.00%> (ø)
...su/src/main/java/org/web3j/protocol/besu/Besu.java 50.00% <0.00%> (-50.00%) ⬇️
.../web3j/protocol/besu/filters/PrivateLogFilter.java 0.00% <0.00%> (ø)
...va/org/web3j/tx/BesuPrivateTransactionManager.java 0.00% <0.00%> (ø)
.../org/web3j/tx/LegacyPrivateTransactionManager.java 0.00% <0.00%> (ø)
...nse/PollingPrivateTransactionReceiptProcessor.java 25.00% <0.00%> (+25.00%) ⬆️
...degen/src/main/java/org/web3j/codegen/Console.java 0.00% <0.00%> (ø)
...j/codegen/TruffleJsonFunctionWrapperGenerator.java 30.84% <ø> (-9.35%) ⬇️
... and 132 more

... and 109 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gtebrean gtebrean merged commit 61b3285 into hyperledger-web3j:master Aug 30, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants