Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating circom version to v2.2.1 #109

Merged
merged 5 commits into from
Dec 10, 2024
Merged

updating circom version to v2.2.1 #109

merged 5 commits into from
Dec 10, 2024

Conversation

Chengxuan
Copy link
Contributor

@Chengxuan Chengxuan commented Dec 7, 2024

This PR updated the circom version to v2.2.1 for #100:

Signed-off-by: Chengxuan Xing <[email protected]>
@Chengxuan Chengxuan changed the base branch from circuit-tool-version-check to main December 7, 2024 09:40
@Chengxuan Chengxuan closed this Dec 7, 2024
@Chengxuan Chengxuan reopened this Dec 7, 2024
Signed-off-by: Chengxuan Xing <[email protected]>
@Chengxuan
Copy link
Contributor Author

using fast simplification, the circuit asset generation reduced from 42 mins to 18 mins:
before:
image

this PR:
image

Copy link
Contributor

@jimthematrix jimthematrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great to see the improvement in the proving key generation time!

@jimthematrix jimthematrix merged commit ca202cf into main Dec 10, 2024
6 checks passed
@jimthematrix jimthematrix deleted the update-circom-v2.2.1 branch December 10, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants