Prepare for circom v2.2.0 upgrade #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Chengxuan
changed the title
Signed-off-by: Chengxuan Xing <[email protected]>
EnriqueL8
reviewed
Dec 2, 2024
|
@EnriqueL8 Thanks for the comments. for Both the formatting and the reason for switching them to use anonymous component syntax are to prepare for organize those loose attributes into "buses" (a concept similar to |
jimthematrix
approved these changes
Dec 3, 2024
| @@ -4,7 +4,7 @@ name: release | |||
| on: | |||
| push: | |||
| tags: | |||
| - 'v*.*.*' | |||
| - "v*.*.*" | |||
There was a problem hiding this comment.
please include vscode settings to make the formatting choice universally applied with any developer
There was a problem hiding this comment.
vscode settings are currently ignored. will remove it from gitignore
There was a problem hiding this comment.
comment addressed in 0ed5a04
Signed-off-by: Chengxuan Xing <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first part of #100
picks up circom v2.2.0 Maintained the usage of(going to be the next PR as changes turns out to be more complicated)--O2optimization since we are using groth16