Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for event after registerNonFinal #11

Open
matthiasgeihs opened this issue Jun 17, 2021 · 0 comments
Open

Wait for event after registerNonFinal #11

matthiasgeihs opened this issue Jun 17, 2021 · 0 comments
Labels

Comments

@matthiasgeihs
Copy link
Contributor

Location: backend/ethereum/channel/register.go

Context: Previously, after calling registerNonFinal, we waited for the corresponding Registered event on the contract. This was changed at some point due to the complex subscription logic involved.

Problem: Currently, we don't wait for the event, and we also do not check that the transaction is correctly mined. We only log a warning. This means that the function call does not return an error if the transaction failed.

Potential fix: As a quick fix, we should return an error if the transaction failed. As a comprehensive fix, we should use again a subscription that checks that corresponding events are emitted.

@ggwpez ggwpez added the bug label Jun 17, 2021
@matthiasgeihs matthiasgeihs transferred this issue from hyperledger-labs/go-perun Jun 14, 2022
@matthiasgeihs matthiasgeihs pinned this issue Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants