Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[suggestion] Simplify logger's behaviour and configuration #4064

Closed
0x009922 opened this issue Nov 21, 2023 · 1 comment
Closed

[suggestion] Simplify logger's behaviour and configuration #4064

0x009922 opened this issue Nov 21, 2023 · 1 comment
Assignees
Labels
config-changes Changes in configuration and start up of the Iroha Enhancement New feature or request good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST UI Something about the interface

Comments

@0x009922
Copy link
Contributor

Description

I think the current logger's behaviour & configuration are a little overcomplicated, and I see a way to make its UX more straightforward and useful.

Current implementation

Iroha prints logs into standard output in default way and optionally into a file in JSON format.

There are these options:

  • level: logging verbosity
  • compact_mode: flag to make logs in the standard output less verbose in terms of format
  • terminal_colors: flag to control ANSI colouring in the standard output
  • log_file_path: enables JSON logging into a file, in a addition to standard output

log_file_path seems not useful for me here. It is the only way to get JSON logs, and if you need JSON logs, than you most probably don't need any other logs. However, stdout is always busy with default logging.

Apart from that, I've created a separate issue for removal of terminal_colors from the logger configuration:

Proposal

So, after all there will be only two options to configure: level and format.

@0x009922 0x009922 added Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST config-changes Changes in configuration and start up of the Iroha UI Something about the interface good first issue Good for newcomers labels Nov 21, 2023
0x009922 added a commit that referenced this issue Dec 12, 2023
…figuration (#4100)

Co-authored-by: ⭐️NINIKA⭐️ <[email protected]>
Signed-off-by: Dmitry Balashov <[email protected]>
@0x009922
Copy link
Contributor Author

Closed by #4100

Asem-Abdelhady pushed a commit to Asem-Abdelhady/iroha that referenced this issue Jan 9, 2024
…ha#4064, hyperledger-iroha#4079: re-architect logger and dynamic configuration (hyperledger-iroha#4100)

Co-authored-by: ⭐️NINIKA⭐️ <[email protected]>
Signed-off-by: Dmitry Balashov <[email protected]>
Asem-Abdelhady pushed a commit to Asem-Abdelhady/iroha that referenced this issue Jan 22, 2024
…ha#4064, hyperledger-iroha#4079: re-architect logger and dynamic configuration (hyperledger-iroha#4100)

Co-authored-by: ⭐️NINIKA⭐️ <[email protected]>
Signed-off-by: Dmitry Balashov <[email protected]>
Signed-off-by: Asem-Abdelhady <[email protected]>
Asem-Abdelhady pushed a commit to Asem-Abdelhady/iroha that referenced this issue Feb 9, 2024
…ha#4064, hyperledger-iroha#4079: re-architect logger and dynamic configuration (hyperledger-iroha#4100)

Co-authored-by: ⭐️NINIKA⭐️ <[email protected]>
Signed-off-by: Dmitry Balashov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config-changes Changes in configuration and start up of the Iroha Enhancement New feature or request good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST UI Something about the interface
Projects
None yet
Development

No branches or pull requests

1 participant