Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard against secrets leakage #3240

Closed
mversic opened this issue Feb 21, 2023 · 3 comments · Fixed by #4457
Closed

Guard against secrets leakage #3240

mversic opened this issue Feb 21, 2023 · 3 comments · Fixed by #4457
Assignees
@dima74
Labels
Chore This is a small task that can be done at any point in time and is easier than others good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@mversic
Copy link
Contributor

mversic commented Feb 21, 2023

Make use of the secrecy crate to prevent the secrets like PrivateKey(are there any other?) from being leaked accidentally by being printed in logs or serialized. Secret wrapper also makes sure that upon dropping the field is zeroized in memory
@mversic mversic added iroha2-dev The re-implementation of a BFT hyperledger in RUST Chore This is a small task that can be done at any point in time and is easier than others good first issue Good for newcomers labels Feb 21, 2023
@dmitrivenger dmitrivenger mentioned this issue Jun 21, 2023
Closed
This was referenced Aug 23, 2023
Open
Closed
@0x009922 0x009922 mentioned this issue Sep 4, 2023
Closed
4 tasks
@DCNick3 DCNick3 self-assigned this Oct 16, 2023
@DCNick3
Copy link
Contributor

DCNick3 commented Oct 16, 2023

I don't think it's feasible at least before we remove the config documentation from the API (as planned by hyperledger-iroha/iroha-rfcs#8). Removing Serialize impl from the key seems to have troubles with the iroha_config_base::proxy::Documented trait. It'll be easier to add secrecy after the removal than to try to work around that now IMO.

@DCNick3 DCNick3 removed their assignment Nov 21, 2023
@0x009922
Copy link
Contributor

0x009922 commented Dec 8, 2023

Documented trait will be removed by:

@mversic mversic mentioned this issue Jan 3, 2024
Merged
5 tasks
@DCNick3 DCNick3 assigned DCNick3 and unassigned DCNick3 Mar 28, 2024
@dima74 dima74 self-assigned this Apr 12, 2024
dima74 added a commit to dima74/iroha that referenced this issue Apr 17, 2024
@dima74
[refactor] hyperledger-iroha#3240: Guard against secrets leakage
f68fb86 
Signed-off-by: Dmitry Murzin <[email protected]>
dima74 added a commit to dima74/iroha that referenced this issue Apr 17, 2024
@dima74
[refactor] hyperledger-iroha#3240: Guard against secrets leakage
ae088ba 
Signed-off-by: Dmitry Murzin <[email protected]>
@dima74 dima74 mentioned this issue Apr 17, 2024
Merged
5 tasks
dima74 added a commit to dima74/iroha that referenced this issue Apr 17, 2024
@dima74
[refactor] hyperledger-iroha#3240: Guard against secrets leakage
4328892 
Signed-off-by: Dmitry Murzin <[email protected]>
dima74 added a commit to dima74/iroha that referenced this issue Apr 17, 2024
@dima74
[refactor] hyperledger-iroha#3240: Guard against secrets leakage
23b0ed9 
Signed-off-by: Dmitry Murzin <[email protected]>
mversic pushed a commit to dima74/iroha that referenced this issue Apr 17, 2024
@dima74 @mversic
[refactor] hyperledger-iroha#3240: Guard against secrets leakage
b7f3aa3 
Signed-off-by: Dmitry Murzin <[email protected]>
mversic pushed a commit to dima74/iroha that referenced this issue Apr 18, 2024
@dima74 @mversic
[refactor] hyperledger-iroha#3240: Guard against secrets leakage
9082e5f 
Signed-off-by: Dmitry Murzin <[email protected]>
mversic pushed a commit to dima74/iroha that referenced this issue Apr 18, 2024
@dima74 @mversic
[refactor] hyperledger-iroha#3240: Guard against secrets leakage
082fb49 
Signed-off-by: Dmitry Murzin <[email protected]>
dima74 added a commit that referenced this issue Apr 18, 2024
@dima74
[refactor] #3240: Guard against secrets leakage
d3f21bb 
Signed-off-by: Dmitry Murzin <[email protected]>
@dima74 dima74 reopened this Apr 18, 2024
@nxsaken
Copy link
Contributor

nxsaken commented May 14, 2024

@dima74 should this be closed?

@dima74 dima74 closed this as completed May 14, 2024
@mversic mversic mentioned this issue Oct 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dima74 dima74

Labels
Chore This is a small task that can be done at any point in time and is easier than others good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[refactor] #3240: Guard against secrets leakage dima74/iroha
5 participants
@dima74 @DCNick3 @nxsaken @0x009922 @mversic