Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The metric monika_probe_result displaying incorrectly #1336

Open
sapiderman opened this issue Dec 13, 2024 · 0 comments · May be fixed by #1338
Open

The metric monika_probe_result displaying incorrectly #1336

sapiderman opened this issue Dec 13, 2024 · 0 comments · May be fixed by #1338
Labels
bug Something isn't working

Comments

@sapiderman
Copy link
Contributor

sapiderman commented Dec 13, 2024

Describe the bug
The monika_probe_result metric is stuck on 1 / success

To Reproduce
Steps to reproduce the behavior:

  1. Using the following config.yaml
probes:
  - id: 'mock-1'
    name: 'local-test-test'
    requests:
      - url: http://0.0.0.0:7001/v1/hello
    alerts:
      - assertion: response.status < 200 or response.status > 308
        message: HTTP Status is not 200

  - id: 'http-1'
    name: 'status-200-test'
    requests:
      - url: https://httpbin.org/status/200
        method: GET
    alerts:
      - assertion: response.status < 200 or response.status > 308
        message: HTTP Status is not 200
      - assertion: response.time > 2000
        message: Too slow
  1. Run monika on npm start -- --prometheus 3001 -c config.yaml
  2. Start your target/mock server (mock-1)
  3. Go to localhost:3001/metric on your browser
  4. After a few minutes disable/turn off the target/mock server (mock-1)

Expected behavior
The metric monika_probe_result should show 0 for a failed probe and 1 for success

Screenshots
both probes running and when mock probe is disabled:
image

Desktop (please complete the following information):

  • OS: Ubuntu LTS 24.04 as WSL on Windows 11
  • Version: Monika in main branch / version 1.21.x
@sapiderman sapiderman added the bug Something isn't working label Dec 13, 2024
@dennypradipta dennypradipta linked a pull request Dec 27, 2024 that will close this issue
@dennypradipta dennypradipta linked a pull request Dec 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant