Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL support #23

Open
rezaervani opened this issue Nov 18, 2020 · 5 comments
Open

RTL support #23

rezaervani opened this issue Nov 18, 2020 · 5 comments

Comments

@rezaervani
Copy link

I read here : #12 that humhub add some features to prosemirror like plugin system. Is there any documentation of it ? Or if I have to refer to prosemirror documentation, on which part ?

I found that every single function of button in humhub-prosemirror-richeditor is separated into single plugin humhub/protected/vendor/npm-asset/humhub-prosemirror-richtext/src/editor/core/plugins

And at least there are two files in every plugin : index.js and schema.js - in some plugins I also found input-rules.js and menu.js

Let said, that I want to add RTL plugin to my humhub-prosemirror, what should I do ? I've tried compare this to the most simple example at prosemirror git, that is prosemirror-menu-master. But I still can't get the idea how humhub-prosemirror-richtext work

I am really interested to learn much more about this. Where should I start ?

Thank you,

@buddh4
Copy link
Contributor

buddh4 commented Dec 3, 2020

See https://discuss.prosemirror.net/t/does-prosemirror-support-rtl-languages-editing/1318 which suggests you probably just have to change your theme (or just add a simple css rule) for this. Can you test the direction style mentioned in this issue and let me know if this works. Maybe we could change the direction by language in v1.8.

@buddh4
Copy link
Contributor

buddh4 commented Dec 3, 2020

Oh, just saw that you already answered in the mentioned issue, if you need help with applying the style let me know.

@buddh4 buddh4 changed the title Documentation for humhub-prosemirror LTR support Dec 3, 2020
@buddh4
Copy link
Contributor

buddh4 commented Dec 3, 2020

@buddh4 buddh4 changed the title LTR support RTL support Dec 3, 2020
@buddh4
Copy link
Contributor

buddh4 commented Dec 3, 2020

Duplicate #22

@rezaervani
Copy link
Author

Thank you, I've tried this for 2 weeks, and get some progress. But I have to split file humhub-editor.js into some files to make my learning more simple.

I'll inform if finally I can make it done

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants