Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update the meta-jobs #857

Merged
merged 1 commit into from
Oct 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/composer-root-version.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
- name: Lint CS
run: cd composer-root-version-checker; make cs_lint

tests:
composer-root-version:
runs-on: ubuntu-latest
name: Tests
strategy:
Expand Down Expand Up @@ -86,9 +86,11 @@ jobs:
# the protected branch rules as opposed to the tests one above which
# may change regularly.
validate-tests:
name: Tests status
name: RootVersionChecker Status
runs-on: ubuntu-latest
needs: tests
needs:
- cs-lint
- composer-root-version
if: always()
steps:
- name: Successful run
Expand Down
8 changes: 5 additions & 3 deletions .github/workflows/e2e-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -154,10 +154,12 @@ jobs:
# may change regularly.
# This allows us to mark only this job as required instead of each individual
# ever-changing E2E tests.
validate-e2e:
name: Check status
validate-tests:
name: End-to-End Tests Status
runs-on: ubuntu-latest
needs: e2e-tests
needs:
- build-test-phar
- e2e-tests
if: always()
steps:
- name: Successful run
Expand Down
22 changes: 22 additions & 0 deletions .github/workflows/lint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -78,3 +78,25 @@ jobs:
run: make phpstan_install

- run: make phpstan

# This is a "trick", a meta task which does not change, and we can use in
# the protected branch rules as opposed to the E2E tests one above which
# may change regularly.
# This allows us to mark only this job as required instead of each individual
# ever-changing E2E tests.
validate-tests:
name: Lint Status
runs-on: ubuntu-latest
needs:
- cs
- phpstan
if: always()
steps:
- name: Successful run
if: ${{ !(contains(needs.*.result, 'failure')) }}
run: exit 0

- name: Failing run
if: ${{ contains(needs.*.result, 'failure') }}
run: exit 1

7 changes: 5 additions & 2 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,12 @@ jobs:
# the protected branch rules as opposed to the tests one above which
# may change regularly.
validate-tests:
name: Unit tests status
name: Unit tests Status
runs-on: ubuntu-latest
needs: unit-tests
needs:
- root-version
- composer-json
- unit-tests
if: always()
steps:
- name: Successful run
Expand Down
Loading