General PR slow CI #30540
General PR slow CI #30540
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ydshieh
force-pushed
the
run_pr_slow_ci
branch
2 times, most recently
from
27c66e0 to
28e438c
Compare
| @@ -4,6 +4,11 @@ on: | |||
| pull_request: | |||
| paths: | |||
| - "src/transformers/models/*/modeling_*.py" | |||
| - "tests/models/*/test_*.py" | |||
There was a problem hiding this comment.
If nothing changed in those paths, the CI won't be triggered at all
(even if the commit message specifies some models)
There was a problem hiding this comment.
Let's keep for now - I'm not sure whether we want this. It's good for the auto model selection, but I can see as being annoying for the run-slow case: I might update e.g. modeling_attn_mask_utils.py and want to be able to easily run the slow tests on a subset of important models
There was a problem hiding this comment.
Yes, we will see 🚀 !
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }} | ||
| cancel-in-progress: true |
There was a problem hiding this comment.
To cancel the CI runs trigger by previous commits of the same PR
| python -m pip install GitPython | ||
| echo "new_model=$(python utils/check_if_new_model_added.py | tail -n 1)" >> $GITHUB_OUTPUT | ||
| python utils/pr_slow_ci_models.py --commit_message "${{ env.commit_message }}" | tee output.txt |
There was a problem hiding this comment.
now that (renamed) script will give the models to run (either new model or from the commit message)
| @@ -4,6 +4,11 @@ on: | |||
| pull_request: | |||
| paths: | |||
| - "src/transformers/models/*/modeling_*.py" | |||
| - "tests/models/*/test_*.py" | |||
There was a problem hiding this comment.
Let's keep for now - I'm not sure whether we want this. It's good for the auto model selection, but I can see as being annoying for the run-slow case: I might update e.g. modeling_attn_mask_utils.py and want to be able to easily run the slow tests on a subset of important models
Co-authored-by: amyeroberts <[email protected]>
* More general PR slow CI * Update utils/pr_slow_ci_models.py Co-authored-by: amyeroberts <[email protected]> --------- Co-authored-by: ydshieh <[email protected]> Co-authored-by: amyeroberts <[email protected]>
What does this PR do?
Extend #30341 to handle general PR slow CI. Now, it could handle
[run-slow]bert,gpt2[run-slow],[run_slow]or[run slow]bert,gpt2orbert, gpt2etc.The script and workflow file names (and their methods or job/step names too) to reflect they handle more general cases instead of just new model cases.
An example run:
[run-slow]bert,gpt2IMPORTANT: the label to add in order to trigger this CI is run-slow.
single-model-run-slowis no longer used.