From 693e7f5d074d6895df97d4acb99e4a66a5aba053 Mon Sep 17 00:00:00 2001 From: Younes Belkada <49240599+younesbelkada@users.noreply.github.com> Date: Fri, 12 Apr 2024 11:39:03 +0200 Subject: [PATCH 01/19] Update push-important-models.yml --- .github/workflows/push-important-models.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/push-important-models.yml b/.github/workflows/push-important-models.yml index 5eef6f40f877cb..936c28e9345551 100644 --- a/.github/workflows/push-important-models.yml +++ b/.github/workflows/push-important-models.yml @@ -2,7 +2,7 @@ name: Slow tests on important models (on Push - A10) on: push: - branches: [ main ] + branches: [ younesbelkada-patch-1 ] env: IS_GITHUB_CI: "1" @@ -133,4 +133,4 @@ jobs: authkey: ${{ secrets.TAILSCALE_SSH_AUTHKEY }} slackChannel: ${{ secrets.SLACK_CIFEEDBACK_CHANNEL }} slackToken: ${{ secrets.SLACK_CIFEEDBACK_BOT_TOKEN }} - waitForSSH: true \ No newline at end of file + waitForSSH: true From 256793cb2a2b85b1c66504912852cc54867bb664 Mon Sep 17 00:00:00 2001 From: Younes Belkada <49240599+younesbelkada@users.noreply.github.com> Date: Fri, 12 Apr 2024 11:40:05 +0200 Subject: [PATCH 02/19] dummy commit --- src/transformers/modeling_utils.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/transformers/modeling_utils.py b/src/transformers/modeling_utils.py index e4fcd2ebc11e6e..ba4230bd50c1ca 100644 --- a/src/transformers/modeling_utils.py +++ b/src/transformers/modeling_utils.py @@ -33,6 +33,7 @@ from typing import Any, Callable, Dict, List, Optional, Set, Tuple, Union from zipfile import is_zipfile + import torch from packaging import version from torch import Tensor, nn From 847f36b357174e2663a85646f102bc4cbd95b931 Mon Sep 17 00:00:00 2001 From: Younes Belkada <49240599+younesbelkada@users.noreply.github.com> Date: Fri, 12 Apr 2024 18:38:54 +0200 Subject: [PATCH 03/19] Update modeling_bark.py --- src/transformers/models/bark/modeling_bark.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/transformers/models/bark/modeling_bark.py b/src/transformers/models/bark/modeling_bark.py index de04614075cf80..c004b23e0bfc36 100644 --- a/src/transformers/models/bark/modeling_bark.py +++ b/src/transformers/models/bark/modeling_bark.py @@ -16,6 +16,7 @@ import math from typing import Dict, Optional, Tuple, Union + import numpy as np import torch from torch import nn From 0501e7cad90ac2f6b7356a0170e0f0b438c5f08c Mon Sep 17 00:00:00 2001 From: Younes Belkada Date: Fri, 12 Apr 2024 18:44:36 +0200 Subject: [PATCH 04/19] test --- .github/workflows/push-important-models.yml | 3 +++ src/transformers/models/bark/modeling_bark.py | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/push-important-models.yml b/.github/workflows/push-important-models.yml index 936c28e9345551..92cd3badd86957 100644 --- a/.github/workflows/push-important-models.yml +++ b/.github/workflows/push-important-models.yml @@ -64,6 +64,9 @@ jobs: model-name: ${{ fromJson(needs.get_modified_models.outputs.matrix) }} steps: + - name: Echo + run: | + echo ${{ needs.get_modified_models.outputs.matrix }} - name: Check out code uses: actions/checkout@v3 diff --git a/src/transformers/models/bark/modeling_bark.py b/src/transformers/models/bark/modeling_bark.py index c004b23e0bfc36..de04614075cf80 100644 --- a/src/transformers/models/bark/modeling_bark.py +++ b/src/transformers/models/bark/modeling_bark.py @@ -16,7 +16,6 @@ import math from typing import Dict, Optional, Tuple, Union - import numpy as np import torch from torch import nn From bcd169d0d18a8df1e689e7fd9f13062413fde3ce Mon Sep 17 00:00:00 2001 From: Younes Belkada Date: Fri, 12 Apr 2024 18:46:52 +0200 Subject: [PATCH 05/19] test --- .github/workflows/push-important-models.yml | 13 +++++++------ src/transformers/models/bark/modeling_bark.py | 1 + 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/.github/workflows/push-important-models.yml b/.github/workflows/push-important-models.yml index 92cd3badd86957..83c7eb2450fc97 100644 --- a/.github/workflows/push-important-models.yml +++ b/.github/workflows/push-important-models.yml @@ -52,11 +52,12 @@ jobs: echo "matrix=[$matrix_string]" >> $GITHUB_OUTPUT test_modified_files: needs: get_modified_models - name: Slow & FA2 tests - runs-on: [single-gpu, nvidia-gpu, a10, ci] - container: - image: huggingface/transformers-all-latest-gpu - options: --gpus all --privileged --ipc host -v /mnt/cache/.cache/huggingface:/mnt/cache/ + name: Slow & FA2 tests ${{ matrix.model-name }} + runs-on: ubuntu-latest + # runs-on: [single-gpu, nvidia-gpu, a10, ci] + # container: + # image: huggingface/transformers-all-latest-gpu + # options: --gpus all --privileged --ipc host -v /mnt/cache/.cache/huggingface:/mnt/cache/ if: ${{ needs.get_modified_models.outputs.matrix != '[]' && needs.get_modified_models.outputs.matrix != '' }} strategy: fail-fast: false @@ -66,7 +67,7 @@ jobs: steps: - name: Echo run: | - echo ${{ needs.get_modified_models.outputs.matrix }} + echo ${{ matrix.model-name }} - name: Check out code uses: actions/checkout@v3 diff --git a/src/transformers/models/bark/modeling_bark.py b/src/transformers/models/bark/modeling_bark.py index de04614075cf80..c004b23e0bfc36 100644 --- a/src/transformers/models/bark/modeling_bark.py +++ b/src/transformers/models/bark/modeling_bark.py @@ -16,6 +16,7 @@ import math from typing import Dict, Optional, Tuple, Union + import numpy as np import torch from torch import nn From b64c43328fb05c0bc3a39295b23393e40bc0f798 Mon Sep 17 00:00:00 2001 From: Younes Belkada Date: Fri, 12 Apr 2024 18:49:27 +0200 Subject: [PATCH 06/19] test --- .github/workflows/push-important-models.yml | 2 +- src/transformers/models/bark/modeling_bark.py | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/push-important-models.yml b/.github/workflows/push-important-models.yml index 83c7eb2450fc97..e7b02e372636c5 100644 --- a/.github/workflows/push-important-models.yml +++ b/.github/workflows/push-important-models.yml @@ -58,7 +58,7 @@ jobs: # container: # image: huggingface/transformers-all-latest-gpu # options: --gpus all --privileged --ipc host -v /mnt/cache/.cache/huggingface:/mnt/cache/ - if: ${{ needs.get_modified_models.outputs.matrix != '[]' && needs.get_modified_models.outputs.matrix != '' }} + if: ${{ needs.get_modified_models.outputs.matrix != '[]' && needs.get_modified_models.outputs.matrix != '' && fromJson(needs.get_modified_models.outputs.matrix) != '' }} strategy: fail-fast: false matrix: diff --git a/src/transformers/models/bark/modeling_bark.py b/src/transformers/models/bark/modeling_bark.py index c004b23e0bfc36..de04614075cf80 100644 --- a/src/transformers/models/bark/modeling_bark.py +++ b/src/transformers/models/bark/modeling_bark.py @@ -16,7 +16,6 @@ import math from typing import Dict, Optional, Tuple, Union - import numpy as np import torch from torch import nn From b5ae6a8615ea9b9fc07a051cb00ba9410f69ae06 Mon Sep 17 00:00:00 2001 From: Younes Belkada Date: Fri, 12 Apr 2024 18:52:01 +0200 Subject: [PATCH 07/19] another test --- .github/workflows/push-important-models.yml | 17 +++++++++-------- src/transformers/models/bark/modeling_bark.py | 1 + 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/.github/workflows/push-important-models.yml b/.github/workflows/push-important-models.yml index e7b02e372636c5..b3691394318b5d 100644 --- a/.github/workflows/push-important-models.yml +++ b/.github/workflows/push-important-models.yml @@ -68,6 +68,7 @@ jobs: - name: Echo run: | echo ${{ matrix.model-name }} + echo ${{ fromJson(needs.get_modified_models.outputs.matrix) }} - name: Check out code uses: actions/checkout@v3 @@ -130,11 +131,11 @@ jobs: status: ${{ steps.run_integration_tests.conclusion}} slack_token: ${{ secrets.CI_SLACK_BOT_TOKEN }} - - name: Tailscale # In order to be able to SSH when a test fails - if: ${{ failure() || runner.debug == '1'}} - uses: huggingface/tailscale-action@ssh-improvments - with: - authkey: ${{ secrets.TAILSCALE_SSH_AUTHKEY }} - slackChannel: ${{ secrets.SLACK_CIFEEDBACK_CHANNEL }} - slackToken: ${{ secrets.SLACK_CIFEEDBACK_BOT_TOKEN }} - waitForSSH: true + # - name: Tailscale # In order to be able to SSH when a test fails + # if: ${{ failure() || runner.debug == '1'}} + # uses: huggingface/tailscale-action@ssh-improvments + # with: + # authkey: ${{ secrets.TAILSCALE_SSH_AUTHKEY }} + # slackChannel: ${{ secrets.SLACK_CIFEEDBACK_CHANNEL }} + # slackToken: ${{ secrets.SLACK_CIFEEDBACK_BOT_TOKEN }} + # waitForSSH: true diff --git a/src/transformers/models/bark/modeling_bark.py b/src/transformers/models/bark/modeling_bark.py index de04614075cf80..c004b23e0bfc36 100644 --- a/src/transformers/models/bark/modeling_bark.py +++ b/src/transformers/models/bark/modeling_bark.py @@ -16,6 +16,7 @@ import math from typing import Dict, Optional, Tuple, Union + import numpy as np import torch from torch import nn From 3de8c05904015f8225f233810d14c12fe71aa546 Mon Sep 17 00:00:00 2001 From: Younes Belkada Date: Fri, 12 Apr 2024 18:53:33 +0200 Subject: [PATCH 08/19] another test --- .github/workflows/push-important-models.yml | 2 +- src/transformers/models/bark/modeling_bark.py | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/push-important-models.yml b/.github/workflows/push-important-models.yml index b3691394318b5d..6466d901a20fab 100644 --- a/.github/workflows/push-important-models.yml +++ b/.github/workflows/push-important-models.yml @@ -58,7 +58,7 @@ jobs: # container: # image: huggingface/transformers-all-latest-gpu # options: --gpus all --privileged --ipc host -v /mnt/cache/.cache/huggingface:/mnt/cache/ - if: ${{ needs.get_modified_models.outputs.matrix != '[]' && needs.get_modified_models.outputs.matrix != '' && fromJson(needs.get_modified_models.outputs.matrix) != '' }} + if: ${{ needs.get_modified_models.outputs.matrix != '[]' && needs.get_modified_models.outputs.matrix != '' && fromJson(needs.get_modified_models.outputs.matrix) != 'Array' }} strategy: fail-fast: false matrix: diff --git a/src/transformers/models/bark/modeling_bark.py b/src/transformers/models/bark/modeling_bark.py index c004b23e0bfc36..de04614075cf80 100644 --- a/src/transformers/models/bark/modeling_bark.py +++ b/src/transformers/models/bark/modeling_bark.py @@ -16,7 +16,6 @@ import math from typing import Dict, Optional, Tuple, Union - import numpy as np import torch from torch import nn From 6394c5841c2953635e2641cc02477e9740eb5673 Mon Sep 17 00:00:00 2001 From: Younes Belkada Date: Fri, 12 Apr 2024 18:55:11 +0200 Subject: [PATCH 09/19] test --- .github/workflows/push-important-models.yml | 3 ++- src/transformers/models/bark/modeling_bark.py | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/push-important-models.yml b/.github/workflows/push-important-models.yml index 6466d901a20fab..597aa41b064199 100644 --- a/.github/workflows/push-important-models.yml +++ b/.github/workflows/push-important-models.yml @@ -49,10 +49,11 @@ jobs: fi done matrix_string=$(printf '"%s", ' "${model_arrays[@]}" | sed 's/, $//') + echo $matrix_string echo "matrix=[$matrix_string]" >> $GITHUB_OUTPUT test_modified_files: needs: get_modified_models - name: Slow & FA2 tests ${{ matrix.model-name }} + name: Slow & FA2 tests runs-on: ubuntu-latest # runs-on: [single-gpu, nvidia-gpu, a10, ci] # container: diff --git a/src/transformers/models/bark/modeling_bark.py b/src/transformers/models/bark/modeling_bark.py index de04614075cf80..c004b23e0bfc36 100644 --- a/src/transformers/models/bark/modeling_bark.py +++ b/src/transformers/models/bark/modeling_bark.py @@ -16,6 +16,7 @@ import math from typing import Dict, Optional, Tuple, Union + import numpy as np import torch from torch import nn From d3b879f31c12ef1e02f9775571c53727f8b557a5 Mon Sep 17 00:00:00 2001 From: Younes Belkada Date: Fri, 12 Apr 2024 18:56:06 +0200 Subject: [PATCH 10/19] final test --- .github/workflows/push-important-models.yml | 2 +- src/transformers/models/bark/modeling_bark.py | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/push-important-models.yml b/.github/workflows/push-important-models.yml index 597aa41b064199..4ec5b01311e3ac 100644 --- a/.github/workflows/push-important-models.yml +++ b/.github/workflows/push-important-models.yml @@ -59,7 +59,7 @@ jobs: # container: # image: huggingface/transformers-all-latest-gpu # options: --gpus all --privileged --ipc host -v /mnt/cache/.cache/huggingface:/mnt/cache/ - if: ${{ needs.get_modified_models.outputs.matrix != '[]' && needs.get_modified_models.outputs.matrix != '' && fromJson(needs.get_modified_models.outputs.matrix) != 'Array' }} + if: ${{ needs.get_modified_models.outputs.matrix != '[]' && needs.get_modified_models.outputs.matrix != '' && needs.get_modified_models.outputs.matrix != "" }} strategy: fail-fast: false matrix: diff --git a/src/transformers/models/bark/modeling_bark.py b/src/transformers/models/bark/modeling_bark.py index c004b23e0bfc36..de04614075cf80 100644 --- a/src/transformers/models/bark/modeling_bark.py +++ b/src/transformers/models/bark/modeling_bark.py @@ -16,7 +16,6 @@ import math from typing import Dict, Optional, Tuple, Union - import numpy as np import torch from torch import nn From 7c864d0dfd185838b71d6c698d549c5b849f1957 Mon Sep 17 00:00:00 2001 From: Younes Belkada Date: Fri, 12 Apr 2024 18:58:04 +0200 Subject: [PATCH 11/19] final test --- .github/workflows/push-important-models.yml | 2 +- src/transformers/models/bark/modeling_bark.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/push-important-models.yml b/.github/workflows/push-important-models.yml index 4ec5b01311e3ac..c1c09ffc9c67cf 100644 --- a/.github/workflows/push-important-models.yml +++ b/.github/workflows/push-important-models.yml @@ -59,7 +59,7 @@ jobs: # container: # image: huggingface/transformers-all-latest-gpu # options: --gpus all --privileged --ipc host -v /mnt/cache/.cache/huggingface:/mnt/cache/ - if: ${{ needs.get_modified_models.outputs.matrix != '[]' && needs.get_modified_models.outputs.matrix != '' && needs.get_modified_models.outputs.matrix != "" }} + if: ${{ needs.get_modified_models.outputs.matrix != '[]' && needs.get_modified_models.outputs.matrix != '' && needs.get_modified_models.outputs.matrix != ' ' }} strategy: fail-fast: false matrix: diff --git a/src/transformers/models/bark/modeling_bark.py b/src/transformers/models/bark/modeling_bark.py index de04614075cf80..c004b23e0bfc36 100644 --- a/src/transformers/models/bark/modeling_bark.py +++ b/src/transformers/models/bark/modeling_bark.py @@ -16,6 +16,7 @@ import math from typing import Dict, Optional, Tuple, Union + import numpy as np import torch from torch import nn From 827c54e078ee41132ff6f4c179b615321c8e5864 Mon Sep 17 00:00:00 2001 From: Younes Belkada Date: Fri, 12 Apr 2024 19:01:23 +0200 Subject: [PATCH 12/19] test --- .github/workflows/push-important-models.yml | 3 +-- src/transformers/models/bark/modeling_bark.py | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/push-important-models.yml b/.github/workflows/push-important-models.yml index c1c09ffc9c67cf..d009f21520e0ce 100644 --- a/.github/workflows/push-important-models.yml +++ b/.github/workflows/push-important-models.yml @@ -59,7 +59,7 @@ jobs: # container: # image: huggingface/transformers-all-latest-gpu # options: --gpus all --privileged --ipc host -v /mnt/cache/.cache/huggingface:/mnt/cache/ - if: ${{ needs.get_modified_models.outputs.matrix != '[]' && needs.get_modified_models.outputs.matrix != '' && needs.get_modified_models.outputs.matrix != ' ' }} + if: ${{ needs.get_modified_models.outputs.matrix != ' ' }} strategy: fail-fast: false matrix: @@ -69,7 +69,6 @@ jobs: - name: Echo run: | echo ${{ matrix.model-name }} - echo ${{ fromJson(needs.get_modified_models.outputs.matrix) }} - name: Check out code uses: actions/checkout@v3 diff --git a/src/transformers/models/bark/modeling_bark.py b/src/transformers/models/bark/modeling_bark.py index c004b23e0bfc36..de04614075cf80 100644 --- a/src/transformers/models/bark/modeling_bark.py +++ b/src/transformers/models/bark/modeling_bark.py @@ -16,7 +16,6 @@ import math from typing import Dict, Optional, Tuple, Union - import numpy as np import torch from torch import nn From c93167a9a8b5c0871bedd2e0729fac5ce83abc4a Mon Sep 17 00:00:00 2001 From: Younes Belkada Date: Fri, 12 Apr 2024 19:02:59 +0200 Subject: [PATCH 13/19] another test --- .github/workflows/push-important-models.yml | 4 +++- src/transformers/models/bark/modeling_bark.py | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/push-important-models.yml b/.github/workflows/push-important-models.yml index d009f21520e0ce..434c7bee3c9bec 100644 --- a/.github/workflows/push-important-models.yml +++ b/.github/workflows/push-important-models.yml @@ -59,7 +59,7 @@ jobs: # container: # image: huggingface/transformers-all-latest-gpu # options: --gpus all --privileged --ipc host -v /mnt/cache/.cache/huggingface:/mnt/cache/ - if: ${{ needs.get_modified_models.outputs.matrix != ' ' }} + if: ${{ needs.get_modified_models.outputs.matrix != '[]' && needs.get_modified_models.outputs.matrix != '' }} strategy: fail-fast: false matrix: @@ -69,6 +69,8 @@ jobs: - name: Echo run: | echo ${{ matrix.model-name }} + echo ${{ needs.get_modified_models.outputs.matrix == '' }} + echo ${{ needs.get_modified_models.outputs.matrix == ' ' }} - name: Check out code uses: actions/checkout@v3 diff --git a/src/transformers/models/bark/modeling_bark.py b/src/transformers/models/bark/modeling_bark.py index de04614075cf80..c004b23e0bfc36 100644 --- a/src/transformers/models/bark/modeling_bark.py +++ b/src/transformers/models/bark/modeling_bark.py @@ -16,6 +16,7 @@ import math from typing import Dict, Optional, Tuple, Union + import numpy as np import torch from torch import nn From 9decf04c35ada768b81c47a0524021e1d5f904bd Mon Sep 17 00:00:00 2001 From: Younes Belkada Date: Fri, 12 Apr 2024 19:07:35 +0200 Subject: [PATCH 14/19] test --- .github/workflows/push-important-models.yml | 1 + src/transformers/models/bark/modeling_bark.py | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/push-important-models.yml b/.github/workflows/push-important-models.yml index 434c7bee3c9bec..fe3fa1c0ff4104 100644 --- a/.github/workflows/push-important-models.yml +++ b/.github/workflows/push-important-models.yml @@ -71,6 +71,7 @@ jobs: echo ${{ matrix.model-name }} echo ${{ needs.get_modified_models.outputs.matrix == '' }} echo ${{ needs.get_modified_models.outputs.matrix == ' ' }} + echo ${{ fromJson(needs.get_modified_models.outputs.matrix) == ' ' }} - name: Check out code uses: actions/checkout@v3 diff --git a/src/transformers/models/bark/modeling_bark.py b/src/transformers/models/bark/modeling_bark.py index c004b23e0bfc36..de04614075cf80 100644 --- a/src/transformers/models/bark/modeling_bark.py +++ b/src/transformers/models/bark/modeling_bark.py @@ -16,7 +16,6 @@ import math from typing import Dict, Optional, Tuple, Union - import numpy as np import torch from torch import nn From 722191a1be8a7831f058df64ec68b3055795ffc3 Mon Sep 17 00:00:00 2001 From: Younes Belkada Date: Fri, 12 Apr 2024 19:09:12 +0200 Subject: [PATCH 15/19] test --- .github/workflows/push-important-models.yml | 1 + src/transformers/models/bark/modeling_bark.py | 1 + 2 files changed, 2 insertions(+) diff --git a/.github/workflows/push-important-models.yml b/.github/workflows/push-important-models.yml index fe3fa1c0ff4104..353130a9e0ab3b 100644 --- a/.github/workflows/push-important-models.yml +++ b/.github/workflows/push-important-models.yml @@ -72,6 +72,7 @@ jobs: echo ${{ needs.get_modified_models.outputs.matrix == '' }} echo ${{ needs.get_modified_models.outputs.matrix == ' ' }} echo ${{ fromJson(needs.get_modified_models.outputs.matrix) == ' ' }} + echo ${{ fromJson(needs.get_modified_models.outputs.matrix)[0] == null }} - name: Check out code uses: actions/checkout@v3 diff --git a/src/transformers/models/bark/modeling_bark.py b/src/transformers/models/bark/modeling_bark.py index de04614075cf80..c004b23e0bfc36 100644 --- a/src/transformers/models/bark/modeling_bark.py +++ b/src/transformers/models/bark/modeling_bark.py @@ -16,6 +16,7 @@ import math from typing import Dict, Optional, Tuple, Union + import numpy as np import torch from torch import nn From 1a26ff36e663be0eca774d4affad59fb95a98f46 Mon Sep 17 00:00:00 2001 From: Younes Belkada Date: Fri, 12 Apr 2024 19:11:01 +0200 Subject: [PATCH 16/19] another test --- .github/workflows/push-important-models.yml | 2 +- src/transformers/models/bark/modeling_bark.py | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/push-important-models.yml b/.github/workflows/push-important-models.yml index 353130a9e0ab3b..679c79b9599f89 100644 --- a/.github/workflows/push-important-models.yml +++ b/.github/workflows/push-important-models.yml @@ -59,7 +59,7 @@ jobs: # container: # image: huggingface/transformers-all-latest-gpu # options: --gpus all --privileged --ipc host -v /mnt/cache/.cache/huggingface:/mnt/cache/ - if: ${{ needs.get_modified_models.outputs.matrix != '[]' && needs.get_modified_models.outputs.matrix != '' }} + if: ${{ needs.get_modified_models.outputs.matrix != '[]' && needs.get_modified_models.outputs.matrix != '' && fromJson(needs.get_modified_models.outputs.matrix)[0] != null }} strategy: fail-fast: false matrix: diff --git a/src/transformers/models/bark/modeling_bark.py b/src/transformers/models/bark/modeling_bark.py index c004b23e0bfc36..de04614075cf80 100644 --- a/src/transformers/models/bark/modeling_bark.py +++ b/src/transformers/models/bark/modeling_bark.py @@ -16,7 +16,6 @@ import math from typing import Dict, Optional, Tuple, Union - import numpy as np import torch from torch import nn From 6a527d3d07653bdfe905d132a3b3ff137c608d40 Mon Sep 17 00:00:00 2001 From: Younes Belkada Date: Fri, 12 Apr 2024 19:11:55 +0200 Subject: [PATCH 17/19] test llama --- src/transformers/models/llama/modeling_llama.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/transformers/models/llama/modeling_llama.py b/src/transformers/models/llama/modeling_llama.py index e1afb61be0dfc6..a9dcbd86477045 100644 --- a/src/transformers/models/llama/modeling_llama.py +++ b/src/transformers/models/llama/modeling_llama.py @@ -93,6 +93,7 @@ def forward(self, hidden_states): ALL_LAYERNORM_LAYERS.append(LlamaRMSNorm) + class LlamaRotaryEmbedding(nn.Module): def __init__(self, dim, max_position_embeddings=2048, base=10000, device=None, scaling_factor=1.0): super().__init__() From 104b1420d6108cbf3c83902704529cee9c6bf3ba Mon Sep 17 00:00:00 2001 From: Younes Belkada Date: Fri, 12 Apr 2024 19:13:59 +0200 Subject: [PATCH 18/19] revert everything --- .github/workflows/push-important-models.yml | 33 ++++++++----------- src/transformers/modeling_utils.py | 1 - .../models/llama/modeling_llama.py | 1 - 3 files changed, 13 insertions(+), 22 deletions(-) diff --git a/.github/workflows/push-important-models.yml b/.github/workflows/push-important-models.yml index 679c79b9599f89..e890b6f2060ddc 100644 --- a/.github/workflows/push-important-models.yml +++ b/.github/workflows/push-important-models.yml @@ -2,7 +2,7 @@ name: Slow tests on important models (on Push - A10) on: push: - branches: [ younesbelkada-patch-1 ] + branches: [ main ] env: IS_GITHUB_CI: "1" @@ -55,10 +55,10 @@ jobs: needs: get_modified_models name: Slow & FA2 tests runs-on: ubuntu-latest - # runs-on: [single-gpu, nvidia-gpu, a10, ci] - # container: - # image: huggingface/transformers-all-latest-gpu - # options: --gpus all --privileged --ipc host -v /mnt/cache/.cache/huggingface:/mnt/cache/ + runs-on: [single-gpu, nvidia-gpu, a10, ci] + container: + image: huggingface/transformers-all-latest-gpu + options: --gpus all --privileged --ipc host -v /mnt/cache/.cache/huggingface:/mnt/cache/ if: ${{ needs.get_modified_models.outputs.matrix != '[]' && needs.get_modified_models.outputs.matrix != '' && fromJson(needs.get_modified_models.outputs.matrix)[0] != null }} strategy: fail-fast: false @@ -66,13 +66,6 @@ jobs: model-name: ${{ fromJson(needs.get_modified_models.outputs.matrix) }} steps: - - name: Echo - run: | - echo ${{ matrix.model-name }} - echo ${{ needs.get_modified_models.outputs.matrix == '' }} - echo ${{ needs.get_modified_models.outputs.matrix == ' ' }} - echo ${{ fromJson(needs.get_modified_models.outputs.matrix) == ' ' }} - echo ${{ fromJson(needs.get_modified_models.outputs.matrix)[0] == null }} - name: Check out code uses: actions/checkout@v3 @@ -135,11 +128,11 @@ jobs: status: ${{ steps.run_integration_tests.conclusion}} slack_token: ${{ secrets.CI_SLACK_BOT_TOKEN }} - # - name: Tailscale # In order to be able to SSH when a test fails - # if: ${{ failure() || runner.debug == '1'}} - # uses: huggingface/tailscale-action@ssh-improvments - # with: - # authkey: ${{ secrets.TAILSCALE_SSH_AUTHKEY }} - # slackChannel: ${{ secrets.SLACK_CIFEEDBACK_CHANNEL }} - # slackToken: ${{ secrets.SLACK_CIFEEDBACK_BOT_TOKEN }} - # waitForSSH: true + - name: Tailscale # In order to be able to SSH when a test fails + if: ${{ failure() || runner.debug == '1'}} + uses: huggingface/tailscale-action@ssh-improvments + with: + authkey: ${{ secrets.TAILSCALE_SSH_AUTHKEY }} + slackChannel: ${{ secrets.SLACK_CIFEEDBACK_CHANNEL }} + slackToken: ${{ secrets.SLACK_CIFEEDBACK_BOT_TOKEN }} + waitForSSH: true diff --git a/src/transformers/modeling_utils.py b/src/transformers/modeling_utils.py index ba4230bd50c1ca..e4fcd2ebc11e6e 100644 --- a/src/transformers/modeling_utils.py +++ b/src/transformers/modeling_utils.py @@ -33,7 +33,6 @@ from typing import Any, Callable, Dict, List, Optional, Set, Tuple, Union from zipfile import is_zipfile - import torch from packaging import version from torch import Tensor, nn diff --git a/src/transformers/models/llama/modeling_llama.py b/src/transformers/models/llama/modeling_llama.py index a9dcbd86477045..e1afb61be0dfc6 100644 --- a/src/transformers/models/llama/modeling_llama.py +++ b/src/transformers/models/llama/modeling_llama.py @@ -93,7 +93,6 @@ def forward(self, hidden_states): ALL_LAYERNORM_LAYERS.append(LlamaRMSNorm) - class LlamaRotaryEmbedding(nn.Module): def __init__(self, dim, max_position_embeddings=2048, base=10000, device=None, scaling_factor=1.0): super().__init__() From cefb20e3bc1d5f7c18fa063a3b2f59c54caab338 Mon Sep 17 00:00:00 2001 From: Younes Belkada Date: Fri, 12 Apr 2024 19:15:43 +0200 Subject: [PATCH 19/19] remove echo --- .github/workflows/push-important-models.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/push-important-models.yml b/.github/workflows/push-important-models.yml index e890b6f2060ddc..cf6c53293f25fe 100644 --- a/.github/workflows/push-important-models.yml +++ b/.github/workflows/push-important-models.yml @@ -49,7 +49,6 @@ jobs: fi done matrix_string=$(printf '"%s", ' "${model_arrays[@]}" | sed 's/, $//') - echo $matrix_string echo "matrix=[$matrix_string]" >> $GITHUB_OUTPUT test_modified_files: needs: get_modified_models