Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[whisper] transcription is different from hf & openai #32900

Closed
4 tasks
jsoto-gladia opened this issue Aug 20, 2024 · 6 comments
Closed
4 tasks

[whisper] transcription is different from hf & openai #32900

jsoto-gladia opened this issue Aug 20, 2024 · 6 comments

Comments

@jsoto-gladia
Copy link

System Info

  • transformers version: 4.40.2
  • Platform: Linux-5.15.0-118-generic-x86_64-with-glibc2.35
  • Python version: 3.10.14
  • Huggingface_hub version: 0.21.4
  • Safetensors version: 0.4.2
  • Accelerate version: 0.24.1
  • Accelerate config: not found
  • PyTorch version (GPU?): 2.1.0+cu121 (True)
  • Tensorflow version (GPU?): not installed (NA)
  • Flax version (CPU?/GPU?/TPU?): not installed (NA)
  • Jax version: not installed
  • JaxLib version: not installed
  • Using GPU in script?:
  • Using distributed or parallel set-up in script?:

Who can help?

No response

Information

  • The official example scripts
  • My own modified scripts

Tasks

  • An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
  • My own task or dataset (give details below)

Reproduction

silence-middle.wav.zip
the following wav file produces

  • with hf whisper repo (tiny model):
    Split infinity, and a time when less is more. Where too much is never
  • with openai whisper repo (tiny model)
    Split infinity, and a time when less is more.

Expected behavior

I would expect the result to be
Split infinity, and a time when less is more. Where too much is never

@jsoto-gladia
Copy link
Author

you are missing the re encoding mechanism happening when eos is reached within a 30s segment

@amyeroberts
Copy link
Collaborator

cc @ylacombe @sanchit-gandhi

@ylacombe
Copy link
Contributor

ylacombe commented Sep 2, 2024

Hey @jsoto-gladia, many thanks for opening this issue!

This looks like an interesting finding, do you think you could provide code snippets (both in transformers and in the whisper repo) to allow us to reproduce it ?

Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot closed this as completed Oct 6, 2024
@ylacombe
Copy link
Contributor

ylacombe commented Oct 7, 2024

Hey @jsoto-gladia, I believe this PR addresses your problem: #33917

@ylacombe ylacombe reopened this Oct 7, 2024
Copy link

github-actions bot commented Nov 1, 2024

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot closed this as completed Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants