Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cross Attention Masking for Grounding DINO #30176

Closed
EduardoPach opened this issue Apr 11, 2024 · 1 comment · Fixed by #30364
Closed

Add Cross Attention Masking for Grounding DINO #30176

EduardoPach opened this issue Apr 11, 2024 · 1 comment · Fixed by #30364
Labels

Comments

@EduardoPach
Copy link
Contributor

Feature request

In the recent GroundingDino PR (#26087) one thing that was missing was the cross-attention masking when running Multiheaded attention between text and image features. The assumption was that for inference the text used would probably be a fixed set of labels, thus not needing the cross-attention masking. However, for a more robust and training-friendly implementation, we should support text cross-attention mask.

Motivation

This was an actual request in the PR of the model from people who are using the transformers implementation on their research see #26087 (comment)

Your contribution

A PR should be open soon 😄

@EduardoPach
Copy link
Contributor Author

c.c. @amyeroberts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants