Make output_dir optional in TrainingArguments

[ChanderG]

Feature request

Currently, there is only 1 required param in creating a TrainingArguments object - output_dir. HFTrainer manually creates an object with a default value "tmp_trainer" if no Args object is passed to it.

Instead, we should make even this one param optional in the TrainingArguments class (and use a default inside the class implementation).

Motivation

This is useful when creating and passing TrainingArguments in other runners - for eg, trl/SFTTrainer. I would like sensible defaults for all params, so that I only specify the particular arguments I am interested in.

Your contribution

I can open a PR, if this is of interest.

[ArthurZucker]

cc @muellerzr sounds good to me wdyt?

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

[artshcherbina]

I've found a workaround using inheritance:

@dataclass
class MyTrainingArguments(TrainingArguments):
    output_dir: str = field(
        default="models",
    )

[huynhducloi00]

not everyone want to save the model