Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add function that computes 4-byte selector from SolError and SolFunction #6

Open
Philogy opened this issue Oct 13, 2024 · 0 comments
Open

Add function that computes 4-byte selector from SolError and SolFunction #6

Philogy opened this issue Oct 13, 2024 · 0 comments
Labels
pre-feature Setup work required for upcoming feature

Comments

@Philogy
Copy link
Contributor

Philogy commented Oct 13, 2024

For later codegen we will need a method that takes the SolError & SolFunction AST types and computes their 4-byte selector. Maybe this can be done using some feature from the alloy crates out-of-the-box?
@Philogy Philogy added the pre-feature Setup work required for upcoming feature label Oct 13, 2024
willco-1 added a commit to willco-1/huff2 that referenced this issue Oct 24, 2024
@willco-1
refactor: compute selectors huff-language#6
fd514e1
@willco-1 willco-1 mentioned this issue Oct 29, 2024
Merged
Philogy pushed a commit that referenced this issue Nov 18, 2024
@willco-1
🚧 Add compute selector helper
679a436 
* wip: poc compute selectors

* refactor: compute selectors  #6

* fix

* remove

* rm unused

* rm unused

* fix: redudant closure / put test back

* clippy

* accidentally broke the test, whoops
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pre-feature Setup work required for upcoming feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Philogy