Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Custom Graphs #59

Open
strefli3 opened this issue May 6, 2013 · 3 comments
Open

Support for Custom Graphs #59

strefli3 opened this issue May 6, 2013 · 3 comments

Comments

@strefli3
Copy link

strefli3 commented May 6, 2013

Currently I am editing collection.modified.cgi and graphdefs.cgi to support some custom rrd files. Is there any interest in having these functions call a third file with custom graph definitions?

@httpdss
Copy link
Owner

httpdss commented May 6, 2013

yes, sure! that refactor would be awesome! ;)

@strefli3
Copy link
Author

strefli3 commented May 6, 2013

Excellent. Do you have any interest in tackling this or should I proceed and try to submit a patch?

If the latter is the case perhaps you have can tell me the reason for both collection.modified.cgi and graphdefs.cgi? My brief audit suggests that the iPhone code calls graphdefs.cgi but I honestly haven't looked at it in depth.

@httpdss
Copy link
Owner

httpdss commented May 9, 2013

well collection.modified.cgi has the core logic and handling of graphdefs. with respect to graphdefs.cgi the idea was to have the possiblity of loading graphdefs on the htmls side for customizing them and executing them (without persistence).
the ideal would be to send all graphs that are on collection.modified.cgi to a new file and thats it. dont get into the graphdefs.cgi cuz im doing something that will change the use of that file.
willing to submit the patch? go for it! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants