Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overflow issue with HSSelect within HSCollapse #537

Open
lenart opened this issue Dec 20, 2024 · 5 comments
Open

Overflow issue with HSSelect within HSCollapse #537

lenart opened this issue Dec 20, 2024 · 5 comments

Comments

@lenart
Copy link

lenart commented Dec 20, 2024

Summary

The menu is clipped due to overflow-hidden on the container

Steps to Reproduce

  1. Open the example on Codepen
  2. Expand the HSCollapse and open the dropdown. It will be clipped - not visible.
  3. I've placed two Select elements in the collapsed section - one uses dropdownScope and one doesn't. Neither work.

I've copied the DOM from existing 2.6 docs.

Demo Link

https://codepen.io/lenart-the-styleful/pen/PwYmmLM

Expected Behavior

No response

Actual Behavior

No response

Screenshots

CleanShot 2024-12-20-22 28 36

@ssmathivanan402
Copy link

I think you missed "dropdownScope" : "window" this in hs-select init.

@lenart
Copy link
Author

lenart commented Dec 26, 2024

I think you missed "dropdownScope" : "window" this in hs-select init.

Thanks for looking at my problem @ssmathivanan402 . I wasn't aware of dropdownScope and while I got excited at first, it turns out not to work as I'd have hoped. I've updated the example, adding one additional select with dropdownScope: window.

yarn.lock

preline@^2.6.0:
  version "2.6.0"
  resolved "https://registry.yarnpkg.com/preline/-/preline-2.6.0.tgz#45dbd007f2a76519bbdaef276a39adbac30b435e"
  integrity sha512-8O9ayfWgicM8w64k6HIXoRafVqI3xsyFhlT/OCR99USR5izlMGvCunAW+HsTtCwWI0V04m96eXcYy8ElYkDqNg==
  dependencies:
    "@popperjs/core" "^2.11.2"

"@popperjs/core@^2.11.2":
  version "2.11.8"
  resolved "https://registry.yarnpkg.com/@popperjs/core/-/core-2.11.8.tgz#6b79032e760a0899cd4204710beede972a3a185f"
  integrity sha512-P1st0aksCrn9sGZhp8GMYwBnQsbvAWsZAX44oXNNvLHGqAOcoVxmjZiohstwQ7SqKnbR47akdNi+uleWD8+g6A==

@ssmathivanan402
Copy link

Preline-HSSelect-HSCollapse-overflow-issue.webm

Hi Lenart. Can you please check this video might useful for you

@ssmathivanan402
Copy link

Simply add Popper.js directly to your page, and everything should work as expected

@lenart
Copy link
Author

lenart commented Jan 2, 2025

@ssmathivanan402 that's great to see/hear. I was under the impression that popper.js is included in the bundled version. Feel free to close this comment. Consider adding more explicit instructions about the dependency to the documentation; Popper.js is mentioned in the dropdownScope property description but like I've said I thought it would be bundled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants