Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move argument parsing in trainer.py from the main method. #60

Open
varisd opened this issue Sep 17, 2024 · 0 comments
Open

Move argument parsing in trainer.py from the main method. #60

varisd opened this issue Sep 17, 2024 · 0 comments
Labels
enhancement New feature or request minor

Comments

@varisd
Copy link

varisd commented Sep 17, 2024

Currently, the command-line argument parsing is performed inside the module's main method. This makes using trainer.main directly in other Python applications difficult.

I suggest moving the argparse part of the code to a separate method (e.g. parse_args) and adding a argparse.Namespace argument to the main method. This way, users can call main method directly from their Python code given that they prepare the input Namespace argument beforehand.

@varisd varisd added enhancement New feature or request minor labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor
Projects
None yet
Development

No branches or pull requests

1 participant