Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In fringe cases snapping of Keyframes does not work as expected #930

Open
linusha opened this issue Jun 3, 2021 · 2 comments
Open

In fringe cases snapping of Keyframes does not work as expected #930

linusha opened this issue Jun 3, 2021 · 2 comments
Labels
bug Something isn't working low ⭐ May be deffered

Comments

@linusha
Copy link
Contributor

linusha commented Jun 3, 2021

In some small amount of scenarios (can only be reproduced by trial-and-error) the snapping of Keyframes will not work. This is due to the implementation of the snapping and how the position of Keyframes is converted into positions of TimelineKeyframes in timeline/index.js.

The solution would be to either purely rely on the model or on the view for snapping. This is however hard and the problem is only apparent in a very small amount of cases.

@linusha linusha added bug Something isn't working low ⭐ May be deffered labels Jun 3, 2021
@T4rikA
Copy link
Contributor

T4rikA commented Jun 14, 2021

Also happens for sequences in overview timeline, happend when dragging tree and day background. The snapping indicator for tree sequence to night background was not shown

@linusha
Copy link
Contributor Author

linusha commented Jun 14, 2021

Also happens for sequences in overview timeline, happend when dragging tree and day background. The snapping indicator for tree sequence to night background was not shown

But it is also only some (edge) cases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low ⭐ May be deffered
Projects
None yet
Development

No branches or pull requests

2 participants