From cbae4cc6028a7b0e9e6326a21789c0b76c324d4f Mon Sep 17 00:00:00 2001
From: Caspar Neumann <caspar.neumann@capgemini.com>
Date: Fri, 27 Oct 2023 11:15:52 +0200
Subject: [PATCH] Add library.entity.spec

---
 .../h5p-editor/entity/library.entity.spec.ts  | 133 ++++++++++++++++++
 .../h5p-editor/entity/library.entity.ts       |   2 +-
 2 files changed, 134 insertions(+), 1 deletion(-)
 create mode 100644 apps/server/src/modules/h5p-editor/entity/library.entity.spec.ts

diff --git a/apps/server/src/modules/h5p-editor/entity/library.entity.spec.ts b/apps/server/src/modules/h5p-editor/entity/library.entity.spec.ts
new file mode 100644
index 00000000000..38dbae3aa1b
--- /dev/null
+++ b/apps/server/src/modules/h5p-editor/entity/library.entity.spec.ts
@@ -0,0 +1,133 @@
+import { ILibraryMetadata } from '@lumieducation/h5p-server';
+import { FileMetadata, InstalledLibrary } from './library.entity';
+
+describe('InstalledLibrary', () => {
+	let addonLibVersionOne: InstalledLibrary;
+	let addonLibVersionOneMinorChange: InstalledLibrary;
+	let addonLibVersionTwo: InstalledLibrary;
+
+	beforeAll(() => {
+		const testingLibMetadataVersionOne: ILibraryMetadata = {
+			runnable: false,
+			title: '',
+			patchVersion: 3,
+			machineName: 'testing',
+			majorVersion: 1,
+			minorVersion: 2,
+		};
+		const testingLibVersionOne = new InstalledLibrary(testingLibMetadataVersionOne);
+		testingLibVersionOne.files.push(
+			new FileMetadata('file1', new Date(), 2),
+			new FileMetadata('file2', new Date(), 4),
+			new FileMetadata('file3', new Date(), 6)
+		);
+
+		const addonLibMetadataVersionOne: ILibraryMetadata = {
+			runnable: false,
+			title: '',
+			patchVersion: 3,
+			machineName: 'addonVersionOne',
+			majorVersion: 1,
+			minorVersion: 2,
+		};
+		addonLibVersionOne = new InstalledLibrary(addonLibMetadataVersionOne);
+		addonLibVersionOne.addTo = { player: { machineNames: [testingLibVersionOne.machineName] } };
+
+		const testingLibMetadataVersionOneMinorChange: ILibraryMetadata = {
+			runnable: false,
+			title: '',
+			patchVersion: 3,
+			machineName: 'testing',
+			majorVersion: 1,
+			minorVersion: 5,
+		};
+		const testingLibVersionOneMinorChange = new InstalledLibrary(testingLibMetadataVersionOneMinorChange);
+		testingLibVersionOne.files.push(
+			new FileMetadata('file1', new Date(), 2),
+			new FileMetadata('file2', new Date(), 4),
+			new FileMetadata('file3', new Date(), 6)
+		);
+
+		const addonLibMetadataVersionOneMinorChange: ILibraryMetadata = {
+			runnable: false,
+			title: '',
+			patchVersion: 3,
+			machineName: 'addonVersionOne',
+			majorVersion: 1,
+			minorVersion: 5,
+		};
+		addonLibVersionOneMinorChange = new InstalledLibrary(addonLibMetadataVersionOneMinorChange);
+		addonLibVersionOneMinorChange.addTo = { player: { machineNames: [testingLibVersionOneMinorChange.machineName] } };
+
+		const testingLibMetadataVersionTwo: ILibraryMetadata = {
+			runnable: false,
+			title: '',
+			patchVersion: 4,
+			machineName: 'addonVersionTwo',
+			majorVersion: 2,
+			minorVersion: 3,
+		};
+		const testingLibVersionTwo = new InstalledLibrary(testingLibMetadataVersionTwo);
+		testingLibVersionTwo.files.push(
+			new FileMetadata('file1', new Date(), 2),
+			new FileMetadata('file2', new Date(), 4),
+			new FileMetadata('file3', new Date(), 6)
+		);
+
+		const addonLibMetadataVersionTwo: ILibraryMetadata = {
+			runnable: false,
+			title: '',
+			patchVersion: 4,
+			machineName: 'addonVersionTwo',
+			majorVersion: 2,
+			minorVersion: 3,
+		};
+		addonLibVersionTwo = new InstalledLibrary(addonLibMetadataVersionTwo);
+		addonLibVersionTwo.addTo = { player: { machineNames: [testingLibVersionTwo.machineName] } };
+	});
+
+	describe('simple_compare', () => {
+		it('should return 1 if a is greater than b', () => {
+			expect(InstalledLibrary.simple_compare(5, 3)).toBe(1);
+		});
+
+		it('should return -1 if a is less than b', () => {
+			expect(InstalledLibrary.simple_compare(3, 5)).toBe(-1);
+		});
+
+		it('should return 0 if a is equal to b', () => {
+			expect(InstalledLibrary.simple_compare(3, 3)).toBe(0);
+		});
+	});
+
+	describe('compare', () => {
+		it('should return -1', () => {
+			const result = addonLibVersionOne.compare(addonLibVersionTwo);
+			expect(result).toBe(-1);
+		});
+		it('should call compareVersions', () => {
+			const compareVersionsSpy = (
+				jest.spyOn(addonLibVersionOne, 'compareVersions') as jest.SpyInstance<any, any>
+			).mockReturnValueOnce(0);
+			addonLibVersionOne.compare(addonLibVersionOne);
+			expect(compareVersionsSpy).toHaveBeenCalled();
+			compareVersionsSpy.mockRestore();
+		});
+	});
+
+	describe('compareVersions', () => {
+		it('should return -1 and call simple_compare once', () => {
+			const simpleCompareSpy = jest.spyOn(InstalledLibrary, 'simple_compare');
+			const result = addonLibVersionOne.compareVersions(addonLibVersionTwo);
+			expect(result).toBe(-1);
+			expect(simpleCompareSpy).toHaveBeenCalledTimes(1);
+		});
+
+		it('should return -1 and call simple_compare three times', () => {
+			const simpleCompareSpy = jest.spyOn(InstalledLibrary, 'simple_compare');
+			const result = addonLibVersionOne.compareVersions(addonLibVersionOneMinorChange);
+			expect(result).toBe(-1);
+			expect(simpleCompareSpy).toHaveBeenCalledTimes(3);
+		});
+	});
+});
diff --git a/apps/server/src/modules/h5p-editor/entity/library.entity.ts b/apps/server/src/modules/h5p-editor/entity/library.entity.ts
index 474a534af01..b86c8afb1db 100644
--- a/apps/server/src/modules/h5p-editor/entity/library.entity.ts
+++ b/apps/server/src/modules/h5p-editor/entity/library.entity.ts
@@ -188,7 +188,7 @@ export class InstalledLibrary extends BaseEntityWithTimestamps implements IInsta
 	@Property()
 	files: FileMetadata[];
 
-	private static simple_compare(a: number, b: number): number {
+	public static simple_compare(a: number, b: number): number {
 		if (a > b) {
 			return 1;
 		}