From 79e676db008968a1a084d014aafde9e1af8d4de7 Mon Sep 17 00:00:00 2001 From: dyedwiper Date: Thu, 16 Nov 2023 15:40:33 +0100 Subject: [PATCH] Remove comments --- apps/server/src/modules/school/api/school.uc.ts | 2 -- .../modules/school/domain/interface/school.repo.interface.ts | 2 -- 2 files changed, 4 deletions(-) diff --git a/apps/server/src/modules/school/api/school.uc.ts b/apps/server/src/modules/school/api/school.uc.ts index d291031af5c..468a208eec6 100644 --- a/apps/server/src/modules/school/api/school.uc.ts +++ b/apps/server/src/modules/school/api/school.uc.ts @@ -44,8 +44,6 @@ export class SchoolUc { const schools = await this.schoolService.getAllSchoolsExceptOwnSchool(query, ownSchoolId, findOptions); - // TODO: Do we want authorization here? At the moment there is no fitting permission. - const dtos = SchoolResponseMapper.mapToListForExternalInviteResponses(schools); return dtos; diff --git a/apps/server/src/modules/school/domain/interface/school.repo.interface.ts b/apps/server/src/modules/school/domain/interface/school.repo.interface.ts index 9ee0d6dd74c..4f3d43e24c8 100644 --- a/apps/server/src/modules/school/domain/interface/school.repo.interface.ts +++ b/apps/server/src/modules/school/domain/interface/school.repo.interface.ts @@ -9,6 +9,4 @@ export interface SchoolRepo { getSchool(schoolId: EntityId): Promise; } -// TODO: How to name the injection token? Should it be a string or a symbol? There are different approaches in our code. Shall we be consistent about it? -// It is even possible to give it the same name as the interface: https://stackoverflow.com/a/70088972/11854580 But that's probably confusing. export const SCHOOL_REPO = 'SCHOOL_REPO';