From 2490c168e1bc71eaed2543ee67d0421be3403568 Mon Sep 17 00:00:00 2001
From: Uwe Ilgenstein <uwe.ilgenstein@dataport.de>
Date: Tue, 10 Sep 2024 17:13:12 +0200
Subject: [PATCH] BC-8063 - Remove excess Method from BoardNode (#5232)

---
 apps/server/src/modules/board/domain/board-node.do.ts      | 7 -------
 .../src/modules/board/service/board-node.service.spec.ts   | 4 ++--
 2 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/apps/server/src/modules/board/domain/board-node.do.ts b/apps/server/src/modules/board/domain/board-node.do.ts
index 1a7a74bbff0..0231bcbca4c 100644
--- a/apps/server/src/modules/board/domain/board-node.do.ts
+++ b/apps/server/src/modules/board/domain/board-node.do.ts
@@ -21,17 +21,10 @@ export abstract class BoardNode<T extends BoardNodeProps> extends DomainObject<T
 		// eslint-disable-next-line @typescript-eslint/ban-ts-comment
 		// @ts-ignore
 		copyProps.domainObject = undefined;
-		// eslint-disable-next-line @typescript-eslint/ban-ts-comment
-		// @ts-ignore
-		copyProps.children = [];
 
 		return copyProps;
 	}
 
-	public getTrueProps(): T {
-		return this.props;
-	}
-
 	get level(): number {
 		return this.ancestorIds.length;
 	}
diff --git a/apps/server/src/modules/board/service/board-node.service.spec.ts b/apps/server/src/modules/board/service/board-node.service.spec.ts
index 90e2cd7fb3c..fbaf972a9ea 100644
--- a/apps/server/src/modules/board/service/board-node.service.spec.ts
+++ b/apps/server/src/modules/board/service/board-node.service.spec.ts
@@ -164,7 +164,7 @@ describe(BoardNodeService.name, () => {
 				const parentNode = cardFactory.build();
 				parentNode.addChild(oldNode);
 
-				boardNodeRepo.findById.mockResolvedValueOnce(new Card({ ...parentNode.getTrueProps() }));
+				boardNodeRepo.findById.mockResolvedValueOnce(new Card({ ...parentNode.getProps() }));
 
 				return {
 					parentNode,
@@ -179,7 +179,7 @@ describe(BoardNodeService.name, () => {
 				await service.replace(oldNode, newNode);
 
 				expect(boardNodeRepo.save).toHaveBeenCalledWith(
-					new Card({ ...parentNode.getTrueProps(), children: [oldNode, newNode] })
+					new Card({ ...parentNode.getProps(), children: [oldNode, newNode] })
 				);
 			});