Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter indicator about number of excluded items #691

Closed
10 tasks done
tamslo opened this issue Dec 29, 2023 · 0 comments
Closed
10 tasks done

Add filter indicator about number of excluded items #691

tamslo opened this issue Dec 29, 2023 · 0 comments
Labels
P: App Project: App Study: Must have T: Feature Type: New Features

Comments

@tamslo
Copy link
Collaborator

tamslo commented Dec 29, 2023

  • Improve "no drug" text (drug might not be included)
  • Change items in filter menu to be better understandable
    • Dropdown ("All drugs" vs. "Currently taken drugs")
    • Warning level buttons
  • Use Drawer instead of menu (possibly using DrawerController)
  • Add numbers behind filter menu items that indicate how many items are shown if selected
  • Add "none" Warning level as own filter button (changes filter builder and filter method in cubit)
  • Style warning level filters and drawer
  • Disable options if null items
  • Add indicator (small circle) to filter if less than all drugs shown
  • Tidy up
    • Remove unused filter l10ns (no unused l10ns left)
    • Adapt "active drugs" wording to "currently taken drugs" everywhere
tamslo added a commit that referenced this issue Feb 20, 2024
tamslo added a commit that referenced this issue Feb 20, 2024
tamslo added a commit that referenced this issue Feb 21, 2024
tamslo added a commit that referenced this issue Feb 23, 2024
* Moves withFilterData up to fix that cubit is closed when closing
  the drawer
* Refactors check whether to get lookups for better debugging
tamslo added a commit that referenced this issue Feb 23, 2024
* Add own file for FilterButton
* Make lookup fetching even better debuggable (not sure why this
  is making problems the whole time)
tamslo added a commit that referenced this issue Feb 23, 2024
tamslo added a commit that referenced this issue Feb 26, 2024
@tamslo tamslo closed this as completed Feb 27, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done (last 14 days) in PharMe Study Preparation Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P: App Project: App Study: Must have T: Feature Type: New Features
Projects
Archived in project
Development

No branches or pull requests

1 participant