Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve routing in app #683

Closed
10 tasks done
tamslo opened this issue Dec 7, 2023 · 0 comments
Closed
10 tasks done

Improve routing in app #683

tamslo opened this issue Dec 7, 2023 · 0 comments
Labels
P: App Project: App Study: Must have T: Enhancement Type: Enhancements of existing features

Comments

@tamslo
Copy link
Collaborator

tamslo commented Dec 7, 2023

  • Login should replace stack
  • Drug selection
    • Add "change later in settings or per drug" to description
    • Pressing continue should overwrite stack
    • Continue should only be possible in onboarding; pass down bool
  • Onboarding
    • It should be possible to navigate back (push next page)
    • Next page should be possible to be null (to go back to settings); if null, text should be "Back to app"
    • Last button should be elevated because swiping right not possible on last page
    • Add property "dismissable" with "x" icon to navigate back
  • Add metadata checkpoints for onboardingDone and initialDrugSelectionDone; initial route of app should depend on this
  • Wrap root tab routes in WillPopScope (false) – test if going back still works for gene and drug detail (it should!)
@tamslo tamslo converted this from a draft issue Dec 7, 2023
@tamslo tamslo added Study: Must have P: App Project: App T: Enhancement Type: Enhancements of existing features labels Dec 7, 2023
tamslo added a commit that referenced this issue Dec 8, 2023
@tamslo tamslo closed this as completed Dec 8, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done (last 14 days) in PharMe Study Preparation Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P: App Project: App Study: Must have T: Enhancement Type: Enhancements of existing features
Projects
Archived in project
Development

No branches or pull requests

1 participant