Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor User Data #680

Open
tamslo opened this issue Nov 28, 2023 · 0 comments
Open

Refactor User Data #680

tamslo opened this issue Nov 28, 2023 · 0 comments
Labels
P: App Project: App T: Refactor Type: Refactoring

Comments

@tamslo
Copy link
Collaborator

tamslo commented Nov 28, 2023

Refactor the ActiveDrugs class; currently, it is not really consistent in the app, when UserDate.instance.activeDrugNames is used (altough only for reading, which was the main aim) and when activeDrugs.names.

Also, activeDrugs is not reset when UserData.erase() is called (it is overwritten though upon downloading the data again, still not really clean); might be possible to tie ActiveDrugs more closely to UserData?

GenotypeResult should have extension to easily get overwritten lookup; possible to include or combine with PhenotypeInformation (handling should at least be moved to own file)?

@tamslo tamslo added P: App Project: App T: Refactor Type: Refactoring labels Nov 28, 2023
@github-project-automation github-project-automation bot moved this to Needs prioritization in PharMe Study Preparation Nov 28, 2023
@tamslo tamslo changed the title Refactor ActiveDrugs Refactor User Data Jan 3, 2024
@tamslo tamslo moved this from Needs prioritization to Nice to Have in PharMe Study Preparation Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P: App Project: App T: Refactor Type: Refactoring
Projects
Status: Nice to Have
Development

No branches or pull requests

1 participant