-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
Ensure do not get the message ``` Error: you need to specify the maximum number of CPU cores to be used at the same time. If you want to use N cores, say --cores N or -cN. For all cores on your system (be sure that this is appropriate) use --cores all. For no parallelization use --cores 1 or -c1. ```
Also fix typo
Out of curiosity, what was the error? |
Giving the
This PR looks good, although we're introducing the flag (by necessity) without saying anything about it. Pedagogically, it would be good to run without After this first instance, it looks like short flags are given; for consistency, we can convert |
Use -c 1 and explain --cores 1
Have used short flags after the first invocation. Not including --cores 1 does not seem to have much pedagogical value as it is specific to this software package rather than something that is generally used. The time could be used for other activities. Have added an explanation for why --cores 1 is required. |
-q has an extra argument. Order of options is important.
@tkphd Can you take a look at this again. The changes can probably also be made to the original repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I have suggested a few minor changes.
Seeing -c 1
repeated in so many places made me wonder whether this parameter can go into a profile early on in the lesson or something, to save some keystrokes?
Also, you should replace |
Thanks. Co-authored-by: Toby Hodges <[email protected]>
Co-authored-by: Toby Hodges <[email protected]>
@tkphd @tobyhodges Think this is ok now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor clarification comment.
Thanks. Co-authored-by: Rohit Goswami <[email protected]>
Set number of cores to prevent an error