Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor datapicker - show the name/description of the link or node #99

Closed
ok1ean opened this issue May 25, 2017 · 5 comments
Closed

Editor datapicker - show the name/description of the link or node #99

ok1ean opened this issue May 25, 2017 · 5 comments
Assignees

Comments

@ok1ean
Copy link

ok1ean commented May 25, 2017

Can you make a small upgrade in one of the files?
The /editor-resources/editor.js file has a function that opens a new browser window:
function openpicker(url).
I think that it would be more convenient for many people to open this window not in the left-upper corner, as now, because now it overlaps the "Properties" window.
Make the call to the window.open function as in the text below (offset as an example) or open in the center of the screen.

function openpicker(url) {
    // make sure it isn't already opened
    if (!newWindow || newWindow.closed) {
        newWindow = window.open("", "cactipicker", "left=300,top=300,scrollbars=1,status=1,height=400,width=400,resizable=1");
    }
@howardjones howardjones self-assigned this May 29, 2017
@howardjones
Copy link
Owner

  1. Surely this depends on where you browser window is?
  2. Why do you need to see both the properties and picker? The plan for the future is that the picker won't be a separate window at all... is there something I'm missing here?

@ok1ean
Copy link
Author

ok1ean commented May 30, 2017

  1. IE, Crome and Opera - in these browsers, with this modification, the windows open equally.
  2. In the properties window we see (e.g. Link from 'Device1' to 'Device2') where we need to take the data source for the graph so that the values and direction on the arrows are correct.
    With a large number of devices in the picker list you have to choose the right one for a long time.

Are there any plans for the future to return the list of the latest selected devices? Or add an option filter devices based on the node name?

@howardjones
Copy link
Owner

#74 and #54 are for restoring the features.

So really, if the picker window showed which item we're talking about, that would also work, and not require anyone to ever move a window.

@ok1ean
Copy link
Author

ok1ean commented May 30, 2017

Yes, if in the picker window will indicate the object to which we select the data source (node names or their labels), it will simplify the work.

@ok1ean ok1ean closed this as completed May 30, 2017
@howardjones
Copy link
Owner

OK - should be simple enough to add in :-) I'm reopening this so it reminds me.

@howardjones howardjones reopened this May 30, 2017
@howardjones howardjones changed the title Small optimization Editor datapicker - show the name/description of the link or node May 30, 2017
howardjones added a commit that referenced this issue Feb 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants