-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please update plugin for Cacti 1.0.0 version #58
Comments
Where did you get documentation for Cacti 1.0 plugins? It seemed to be a complete rewrite to make Weathermap work with 1.0... Also, I can't see what you changed in this zip file apart from adding the INFO file. |
I not have documentation for Cacti 1.0 plugins. I'm look for logs and find problem, than i find new function in Cacti 1.0 and change plugin weathermap for new function. |
OK, but which function? I can't just unzip your zip file over the top of my copy without knowing what the changes are. In Github, you should usually make a pull request with the changes. I at least need to know what you changed... |
It's my change plugin. repack |
Thanks, I'll take a look at the patch, (and Cacti 1.0!) Github pull requests are still the best/correct way to do this, though, for the future |
|
Here is something that I have done to make Weathermap functional in Cacti 1.0. However, it looks like Howie is looking at a much larger refactor. This effort took about 8 hours, and could be redone. Things that were completed in this patch include:
I believe this is based upon Weathermap 0.98a. Howie, if I were to do this again, what branch should I do it in? If you can let me know, I'll work on a pull request. |
Thanks cigamit! I'm a bit confused - how do you not know where the source came from? No worries about putting more time into it - I'll take a look at this... the database-refactor branch is the actual current code. At first glance, it looks like you got the right one (WeathermapManager and the PDO stuff doesn't exist in any other branch). |
I followed breadcrumbs from the bug logged on the Cacti GitHub back to here. The user pautiina left a zip file that I used as a starting point. I know now that it was the refactor branch. Please note that there is an error in setup.php line 589. Remove the space between index.php:, weathermap-cacti-plugin-mgmt.php:. I also noted that there is a syntax error Tests/WeathermapManagerTest.php. There may be other issues that have not been addressed, but it's pretty much converted with essentially the current functionality. |
It's all error have only in plugin what I download here. Later, I will update the version from Github and start testing again. Thank you. |
@pautiina I think you have an older version of editor.php. The current one in the database-refactor branch doesn't mention $max_bandwidth_in_cfg. This is a relatively recent change (about 2 months ago). This is the version you should have: https://github.com/howardjones/network-weathermap/tree/database-refactor You should probably grab editor.inc.php too, since that will also have changed. [this is the kind of problem that pull requests solve, by the way] |
@howardjones Maybe I have old version.
After this plugin disabled.
I comment line 14 and error all away |
The function html_graph_start_box() is no longer in Cacti 1.0.x. Should use the html_start_box() and html_end_box(). |
@cigamit what is this in response to? Where are you talking about? I hardly added any of the Cacti 1.0 plugin yet... |
@howardjones He talk about my error |
Hello. |
Thank you for the update. I haven't had a chance to fully test! |
I have some problem. |
As a first guess (I'm not by my PC) - copy weathermap-cacti-plugin-editor.php to weathermap-cacti10-plugin-editor.php I started by separating out the 0.8.8 and 1.0 plugins completely - but that particular file for the editor is (probably) the same in both. I hope to reduce the amount of version-specific code, to make maintenance easier. |
I try copy weathermap-cacti-plugin-editor.php to weathermap-cacti10-plugin-editor.php, but after this my account is logout when I try open editor. |
OK, so it will take a little more work than copying the file :-) I will try to take a look later. Sounds like it could just be as simple as making a variable for $CACTI_PLUGIN_NAME so that the return URL can be constructed correctly though. In your last message - what do you mean by "try open editor" in the first sentence? I see the second one is by clicking on the map name in the plugin. Do you mean just by going to editor.php in your browser? |
NO, I mean when I first try copy weathermap-cacti-plugin-editor.php to weathermap-cacti10-plugin-editor.php and click for link Editor on |
I also have test
Maps not Cycling on FullScrean.
|
Hello. I have retest your change. |
@howardjones right-click show source did the trick! this is on line 9: |
No, that's on me. The script should be formatting it correctly. Thanks for confirming. |
Also be aware that thold plugin has renamed a few columns on its tables for the version compatible with 1.x so I guess the old one hasn't been updated. |
Hey, I have the same problem as @Melantrix. Tested on Chrome and Firefox the picker: https://grafice/plugins/weathermap/cacti-pick.php?action=link_step1 it's perfectly formatting. I can't pick up a data source. It's only text, no link. I run the tests on links. My line 9: |
Missing files: |
@YATV - scroll up a few comments. They are supposed to be missing. I don't want to have other people libraries in the repo. You use 'bower install' to collect those up. This is done before a release is made, so the final zipped release does contain them, but a git clone shouldn't. |
@Melantrix @cosu77 - I think I have resolved this path problem now. Please confirm. (And then I will close this issue, because it has become a giant mess of interweaved conversations! :-) We can create separate issues for specific problems - most of the remaining work for PDO/Cacti 1.0 already has separate tickets) |
Hello.
My database have |
The first one (utf8mb4) I have run into with Cacti itself recently... you didn't get any errors there? The second one is already mentioned in this (too long) thread - not a new bug, just an outstanding task. |
Latest commit should resolve utf8mb4 issue (hopefully nothing regularly uses more than 190 chars!) |
Hi, I haven't found information on network-weathermap.com about downloading or testing the cacti 1.x plugin. In case I'd be happy to contribute with some tests, just can you tell me where is the repository for it? is it a dedicated branch? Thank you in advance, |
That's not a node. Did you check the box that says "Also fill in graph URL"? |
I'm sorry, I did not check the box. It's work. |
@jpobeda: you need to do the bower thing. please see this: 155965e thank you. |
@cosu77 OK, agreed about the cursor. But if you click on them, does it populate? I think you will probably get nearly the result you expect. My problem list for the picker is currently:
|
@howardjones yes, on Data Source. no, on Info URL & 'Hover' Graph URL |
I've just push a new commit for 1 and 2 on my list. |
That's embarrassing ... sorry. It's OK, i have Info URL & 'Hover' Graph URL on my maps. Thank you. |
@howardjones Thanks for looking into this. I can't update the current plugin at this time because of time :D when i do and if i run into problems i will open a new issue, i agree with you it has been a too long thread already. Thanks for the work so far! |
(and the utf8mb4 issue is now #76) |
Now being actively development of new Cacti 1.0.0. Please help prepare for Cacti 1.0.0 Release
https://github.com/Cacti/cacti/issues/249
I have plugin 0.98a with my change. This pugin work on Cacti 1.0.0 and have new api, but I not a programmer and my change plugin have some mistake.
weathermap.zip
The text was updated successfully, but these errors were encountered: