Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty States Missing and Improper Error Handling on PO Review Detail Page #307

Open
Adameddy26 opened this issue Nov 28, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Adameddy26
Copy link

Current behavior

Missing Empty State - PO Items:
When all uploaded CSV PO items are missing, the page does not display any feedback or empty state message, leaving the user unaware of what went wrong.

Missing Empty State - Facilities Modal:
The modal remains blank when all facilities are properly linked, providing no confirmation or feedback to the user.

Improper Error Handling:
Despite errors like:
Date-time parsing issues
Missing products
Missing facilities
The app allows the file upload, creates a record in OMS, and marks the status as Finished, misleading the user into believing the file was processed successfully.

Mapping Chip State Issue:
When a mapping chip is selected, and the user discards changes or uploads a new file, the chip incorrectly remains pre-selected and disabled, causing confusion during subsequent actions.

Expected behavior

Empty States:
Display appropriate empty state messages for

  1. Missing PO items on the PO Review Detail Page.
  2. Missing Facilities Modal when all items are linked.

Error Handling:
Notify the user of specific issues (e.g., date-time parse errors, missing products, missing facilities).
Clearly indicate that problematic items will not be processed, but valid ones will proceed successfully.

Mapping Chip State:
Reset the chip state when the user discards changes or uploads a new file.

Steps to reproduce the issue

Case 1
Upload a CSV file with POs where some items are missing or contain errors (e.g., date-time parse issues, missing products/facilities).
Navigate to the PO Review Detail Page:
Observe the absence of an empty state when no items are present.

Case 2
Upload a CSV file with POs having correct data.
Open the Missing Facilities Modal:
Observe the absence of an empty state when all items are linked properly.

Case 3
Upload a CSV file with POs where some items are missing or contain errors (e.g., date-time parse issues, missing products/facilities).
Upload the file and check OMS:
Note that the file upload is marked Finished, despite errors.

Case 4
Upload a CSV file with POs having correct data.
Select a mapping chip, discard changes, and upload a new file:
Observe the mapping chip's persistent pre-selection.

Environment details

App version : v2.18.1
App environment : UAT

@Adameddy26 Adameddy26 added the bug Something isn't working label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant