From 75baec5aa7aab5cf9ceabfcc14751057035078f2 Mon Sep 17 00:00:00 2001 From: R-Sourabh Date: Thu, 2 May 2024 20:37:00 +0530 Subject: [PATCH 1/3] Fixed: When no product stores are selected, the chip within a facility group should display "0"(#253) --- src/views/FindGroups.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/views/FindGroups.vue b/src/views/FindGroups.vue index 8a0c1e62..5e5ffcb7 100644 --- a/src/views/FindGroups.vue +++ b/src/views/FindGroups.vue @@ -41,7 +41,7 @@ {{ translate('Product stores') }} - {{ group.productStoreCount }} + {{ group.productStoreCount || 0 }} From 6526d4b9ae3fe897b751085dcddab57d037b540d Mon Sep 17 00:00:00 2001 From: R-Sourabh Date: Fri, 3 May 2024 11:43:12 +0530 Subject: [PATCH 2/3] Fixed: Save(fab-button) is not overlap and added loader while opening popup(#253) --- src/components/AddProductStoreToGroupModal.vue | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/components/AddProductStoreToGroupModal.vue b/src/components/AddProductStoreToGroupModal.vue index fc63f74f..9b3c7715 100644 --- a/src/components/AddProductStoreToGroupModal.vue +++ b/src/components/AddProductStoreToGroupModal.vue @@ -55,6 +55,8 @@ import logger from "@/logger"; import { hasError } from "@/adapter"; import { showToast } from "@/utils"; import { DateTime } from "luxon"; +import emitter from "@/event-bus"; + export default defineComponent({ name: "AddProductStoreToGroupModal", @@ -96,6 +98,7 @@ export default defineComponent({ modalController.dismiss({ dismissed: true}); }, async fetchGroupProductStores() { + emitter.emit('presentLoader') try { const resp = await FacilityService.fetchAssociatedProductStoresToGroup({ "inputFields": { @@ -106,6 +109,7 @@ export default defineComponent({ "noConditionFind": "Y", "filterByDate": 'Y' }) + emitter.emit('dismissLoader'); if(!hasError(resp)) { this.selectedProductStores = resp.data.docs @@ -182,4 +186,9 @@ export default defineComponent({ }, }); + \ No newline at end of file From e7bdf55fc3e10fea0842622e1e0d2f939fd3f5d8 Mon Sep 17 00:00:00 2001 From: R-Sourabh Date: Fri, 3 May 2024 18:43:22 +0530 Subject: [PATCH 3/3] Updated: change the position of dismiss loader(#253) --- src/components/AddProductStoreToGroupModal.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/AddProductStoreToGroupModal.vue b/src/components/AddProductStoreToGroupModal.vue index 9b3c7715..f77b1e88 100644 --- a/src/components/AddProductStoreToGroupModal.vue +++ b/src/components/AddProductStoreToGroupModal.vue @@ -109,7 +109,6 @@ export default defineComponent({ "noConditionFind": "Y", "filterByDate": 'Y' }) - emitter.emit('dismissLoader'); if(!hasError(resp)) { this.selectedProductStores = resp.data.docs @@ -120,6 +119,7 @@ export default defineComponent({ } catch(err) { logger.error(err) } + emitter.emit('dismissLoader'); }, isSelected(productStoreId: any) { return this.selectedProductStoreValues.some((productStore: any) => productStore.productStoreId === productStoreId);