From 755fab4ca28b11a17b698e2d44132474f55be8bb Mon Sep 17 00:00:00 2001 From: amansinghbais Date: Tue, 13 Aug 2024 16:45:14 +0530 Subject: [PATCH 1/2] Improved: added prefix to the firebase secrets so to handle dev deployment --- .github/workflows/firebase-hosting-release.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/firebase-hosting-release.yml b/.github/workflows/firebase-hosting-release.yml index 4cb1d892f..bd9e1e1c3 100644 --- a/.github/workflows/firebase-hosting-release.yml +++ b/.github/workflows/firebase-hosting-release.yml @@ -14,5 +14,5 @@ jobs: secrets: envPAT: ${{ secrets.envPAT }} HOTWAX_PUBLIC_SECRET: ${{ secrets.HOTWAX_PUBLIC_SECRET }} - VUE_APP_FIREBASE_CONFIG: ${{ secrets.VUE_APP_FIREBASE_CONFIG }} - VUE_APP_FIREBASE_VAPID_KEY: ${{ secrets.VUE_APP_FIREBASE_VAPID_KEY }} \ No newline at end of file + VUE_APP_FIREBASE_CONFIG: ${{ secrets.DEV_VUE_APP_FIREBASE_CONFIG }} + VUE_APP_FIREBASE_VAPID_KEY: ${{ secrets.DEV_VUE_APP_FIREBASE_VAPID_KEY }} \ No newline at end of file From 6bc3c81de5f6596958c90649986ceb355a40940c Mon Sep 17 00:00:00 2001 From: amansinghbais Date: Tue, 13 Aug 2024 16:49:04 +0530 Subject: [PATCH 2/2] Improved: secrets used on the running of merge workflow --- .github/workflows/firebase-hosting-merge.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/firebase-hosting-merge.yml b/.github/workflows/firebase-hosting-merge.yml index 46f0a1040..0578fe7b3 100644 --- a/.github/workflows/firebase-hosting-merge.yml +++ b/.github/workflows/firebase-hosting-merge.yml @@ -14,5 +14,5 @@ jobs: secrets: envPAT: ${{ secrets.envPAT }} HOTWAX_PUBLIC_SECRET: ${{ secrets.HOTWAX_PUBLIC_SECRET }} - VUE_APP_FIREBASE_CONFIG: ${{ secrets.VUE_APP_FIREBASE_CONFIG }} - VUE_APP_FIREBASE_VAPID_KEY: ${{ secrets.VUE_APP_FIREBASE_VAPID_KEY }} \ No newline at end of file + VUE_APP_FIREBASE_CONFIG: ${{ secrets.DEV_VUE_APP_FIREBASE_CONFIG }} + VUE_APP_FIREBASE_VAPID_KEY: ${{ secrets.DEV_VUE_APP_FIREBASE_VAPID_KEY }} \ No newline at end of file