Tasking manager fastapi #6649
Tasking manager fastapi #6649
Conversation
Signed-off-by: eternaltyro <[email protected]>
Signed-off-by: eternaltyro <[email protected]>
Signed-off-by: eternaltyro <[email protected]>
Signed-off-by: eternaltyro <[email protected]>
Signed-off-by: eternaltyro <[email protected]>
Signed-off-by: eternaltyro <[email protected]>
Signed-off-by: eternaltyro <[email protected]>
Signed-off-by: eternaltyro <[email protected]>
- Build multi-stage container images on specific targets - in this case 'prod' - Better naming for jobs Signed-off-by: eternaltyro <[email protected]>
- Fix outputs format - Experiment with metadata parsing in different ways - Add labels back to container metadata Signed-off-by: eternaltyro <[email protected]>
Signed-off-by: eternaltyro <[email protected]>
Signed-off-by: eternaltyro <[email protected]>
Signed-off-by: eternaltyro <[email protected]>
Signed-off-by: eternaltyro <[email protected]>
Signed-off-by: eternaltyro <[email protected]>
Signed-off-by: eternaltyro <[email protected]>
Signed-off-by: eternaltyro <[email protected]>
Signed-off-by: eternaltyro <[email protected]>
* Project mapping type filter fixed.
* Partners CRUD * Mapswipe and statistics. * Project partnerships. * Request user display name made None if not authenticated. * Routes updated for partners, partnerships and statistics.
| @@ -28,7 +25,7 @@ FROM base as extract-deps | |||
| RUN pip install --no-cache-dir --upgrade pip | |||
| WORKDIR /opt/python | |||
| COPY pyproject.toml pdm.lock README.md /opt/python/ | |||
| RUN pip install --no-cache-dir pdm==2.18.1 | |||
| RUN pip install --no-cache-dir pdm==2.8.0 | |||
There was a problem hiding this comment.
Small thing, but it might be worth updating pdm to 2.18.1 here to avoid downgrading on merge
backend/api/annotations/resources.py
Outdated
| router = APIRouter( | ||
| prefix="/projects", | ||
| tags=["projects"], | ||
| dependencies=[Depends(get_db)], |
There was a problem hiding this comment.
I'm not sure this is needed here. Some endpoints may not need a db connection and this would create one anyway. I'm not sure how you would access the database connection variable like this anyway
| """ | ||
| Get all task annotations for a project | ||
| --- | ||
| tags: |
There was a problem hiding this comment.
Entirely optional, but you could always delete this docstrings. Fastapi generates the OpenAPI docs using typing anyway, so it's a bit redundant. It also means you need to remember to update the docstring if you update variables
| category_dto = await MappingIssueCategoryService.get_mapping_issue_category_as_dto( | ||
| category_id, db | ||
| ) | ||
| return category_dto.model_dump(by_alias=True) |
There was a problem hiding this comment.
This will work, but the preferred approach to a manual model dump is probably using response_model on the endpoint decorator. This will handle serialisation and dumping
| sort_by = request.query_params.get("sortBy", "date") | ||
| sort_direction = request.query_params.get("sortDirection", "desc") | ||
| message_type = request.query_params.get("messageType", None) | ||
| from_username = request.query_params.get("from") |
There was a problem hiding this comment.
This is an interesting approach for endpoint query params. It should work, but typically you would define query params as function arguments and they would be parsed as such. If there is confusion, it's possible to explicitly define arguments as fastapi.Query
| async with db.transaction(): | ||
| await CampaignService.create_campaign_organisation( | ||
| organisation_id, campaign_id, db | ||
| ) | ||
| message = "campaign with id {} assigned for organisation with id {}".format( |
There was a problem hiding this comment.
F-strings are a bit nicer to read, but not a big deal 👍
| return token.model_dump(by_alias=True) | ||
|
|
||
|
|
||
| @router.patch("/authentication/applications/{application_key}/") |
There was a problem hiding this comment.
Using a PATCH method here seems a bit out of place, but maybe I am missing something
|
That's a lot of code changed! Well done on this - lots of great work 🙌 Just a few minor comments |
Remove db connection dependency in routers
* messaging tasks added to background. * db context added in tasks and removed explicit connection. * send message on project progress. * project transfer messaging.
* Concurrent task validation using asyncio gather * messaging tasks added to background. * db context added in tasks and removed explicit connection. * send message on project progress. * project transfer messaging.
fix: Recommended projects, my tasks in my contrib section and cleanups
* Auto unlock task refactored. * Auto unlock task cron job. * Task geojson export.
* Asyncio cron job scheduler set up. * Auto unlock task refactored. * Auto unlock task cron job. * Task geojson export.
Aoi, tasks and project non geometries exports and cleanups
|
What type of PR is this? (check all applicable)
Related Issue
Related discussions:
#6264
https://community.openstreetmap.org/t/migrating-tasking-manager-from-flask-to-fastapi-and-psycopg2-to-asyncpg/116543
Describe this PR
This PR includes the TM fastapi migration and covers the commits from the initial phases of the migration.
This PR is made for the code review of the migration and is NOT be merged currently.