Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastAPI testing for Mapping and Validation workflow. #6617

Open
manjitapandey opened this issue Nov 6, 2024 · 15 comments
Open

FastAPI testing for Mapping and Validation workflow. #6617

manjitapandey opened this issue Nov 6, 2024 · 15 comments
Assignees
Labels
scope: backend status: testing Does it really work or is it pretending to work? tech-debt 💣

Comments

@manjitapandey
Copy link

manjitapandey commented Nov 6, 2024

Go to the Explore Projects page by clicking here.
Testing the Explore Projects Page:

  • Verify that project cards are displayed across different pages.
  • Confirm that the map next to each project card can be shown or hidden.
  • Apply filters for specific projects; confirm that results update as expected.
  • Download project data as a CSV file and confirm it downloads without issues.

Testing Project Details Page:

  • Click on any project card to open its Project Details page.
  • Check that you can both view and post project-specific questions and comments.
  • Test marking projects as favourites by clicking on ‘mark as favourite’ on the bottom ribbon of the project details page. Also try removing the project from your favourite.
  • Confirm that similar projects and the contribution timeline are visible and accurate.

Contributing to a Project:

  • Click on the Contribute button at the bottom right corner and confirm that it takes you to the project’s Tasks page.
  • On the Tasks Page:
  • Users should be able to view project’s instructions.
  • Users should be able to view the Contributions on the contribution tab. Try applying the filters of the contribution tab and verify the filtered data is correct.
  • Verify that the status of tasks is visible and accurate when viewed on the map.
  • Confirm that you can access the history (Activities and comments) of individual tasks. Also verify that you can post comments on the specific task.

Mapping or Validating a Task:
Select a task and click Map selected task. Verify that you are redirected to the iD Editor page as expected. Once on the iD Editor Page, please test the following mapping actions:

  • Attempt to lock the task for mapping.
  • Split the Task: Test splitting the task into smaller segments.
  • Try marking the task as fully mapped.
  • Mark the task as invalid (e.g., mark it as bad imagery )
  • Test stopping the mapping process midway clicking on stop mapping.
  • Switch Editors: Change the editor from iD Editor to JOSM and other available editors

Validation actions:

  • Lock a single task for validation.
  • Lock multiple mapped tasks for validation.
  • Test stopping the validation process midway clicking on stop validation.
  • Try marking the tasks as both validated and invalidate and observe if the status is updated correctly on map through colours.
  • Try adding the comments on the task and confirm that its posted and tagged.

Note: You can only map a single task at a time but validate more than one mapped task on one go.
Note: You don’t need to actually map or validate the tasks in order to mark them as mapped or validated. The projects here are only for testing purposes.

Add the related issues on the comments

@ramyaragupathy ramyaragupathy added scope: backend status: testing Does it really work or is it pretending to work? tech-debt 💣 labels Nov 13, 2024
@manjitapandey manjitapandey added this to the FastAPI migration milestone Nov 14, 2024
@dusanzivkovic
Copy link

OSM username: dusziv
Date of testing: 14 Nov 2024
Issues I have encountered:

Testing the Explore Projects Page:

  • Free text search only searches for text in the project description, not in the project title as well, as in regular TM.
  • Downloaded CSV file contains only the data type (object), not the data.

Testing Project Details Page:

  • I can't post a comment on the project details page. I get an error message.

Mapping or Validating a Task:

  • I can't validate nor invalidate a task. I get an error message.
  • However, if I add a comment to the task, (and then stop the validation), it remains recorded in the history tab.

@manjitapandey
Copy link
Author

Thanks @dusanzivkovic , That's really helpful
Can you please share the project id where you encountered the error related project details and mapping and validating task.
Also if you could share the related screenshot.

@dusanzivkovic
Copy link

@manjitapandey I can't post comment on any task I tried, here's a screenshot of my attempt with project 57.

comment

Then I tried to validate task 74 project 110. The task has previously been marked as ready for validation (light blue). I could not validate it (an error message briefly appeared in the bottom left). But now the color of the task has changed to white.

task74

I have also put a comment on this task and I can see it in the task history.

task74c

Possibly it is because the task status came with project, I can't see anyone in the contributors list

@adiatmad
Copy link

I can't post a comment on a specific task
image

@adiatmad
Copy link

This step is FAILED on my end, using Firefox 132.0.2 (64-bit)

  • Try marking the tasks as both validated and invalidate and observe if the status is updated correctly on map through colours.

image

@manjitapandey
Copy link
Author

Confirming the behavior on my device. Thanks for raising the issue. @dusanzivkovic , @adiatmad

@martien-176
Copy link

martien-176 commented Nov 18, 2024

https://docs.google.com/document/d/1UaZQiePkFxmh26i8CvGmnehfTToc0EGUkceJNqvfFvY/edit?tab=t.0
Browser: Google Chrome Version 131.0.6778.70

This is a copy of the workflow doc with additional notes about test results.

I will write a recap of these hereafter.

@martien-176
Copy link

martien-176 commented Nov 18, 2024

Attention: this is a draft, and not finished yet.


Scenario 1: When the User is Not Logged In

Apply filters and use the search bar; verify that results update according to the filter/search criteria.

  • Button “More filters” does not turn red when using "More filter" -> “Interests”.
  • Search works fine: both description and title is included
  • "Sort by" -> "New projects" & "Old projects" is not sorting properly as to newest first etc.
  • More filter -> Types of mapping: not working. Eg selecting "buildings, Exact match" shows all projects (21 total), including the ones without buildings. Selecting "buildings, not exact match" shows no projects at all

Download project data as a CSV file and confirm it downloads without issues.- only after rebase and refactoring.

  • Download CSV works. But the file contains only the string “[object Object]” in cell A1

Scenario 2: When the User is Logged In

Apply filters and search for specific projects; confirm that results update as expected.

  • Logged in shows 24 projects, logged out 21 projects. Diff caused by diff in Moderate projects
  • Button “More filters” does not turn red when using filter “Interests”.
  • Search works fine: both description and title is included
  • "Sort by" -> "New projects" & "Old projects" is not sorting properly as to newest first etc.
  • "More filters" -> "Types of mapping": when selecting a feature, eg building, in Partner field error message appears: "Something went wrong! Try again later."

@manjitapandey
Copy link
Author

@adiatmad , @dusanzivkovic, We have fixed the issues you raised. Can you confirm if the issues are resolved?

@dusanzivkovic
Copy link

@manjitapandey yes, I can confirm that issues with posting comments and validating tasks are now resolved, and the task status is correctly updated through colors.

@adiatmad
Copy link

I can't post a comment on a specific task image

It's all fixed now, thanks a lot! @manjitapandey

@adiatmad
Copy link

This step is FAILED on my end, using Firefox 132.0.2 (64-bit)

* Try marking the tasks as both validated and invalidate and observe if the status is updated correctly on map through colours.

image

It's all fixed now, thanks a lot! @manjitapandey

@petya-kangalova
Copy link
Collaborator

Adding a few screenshots from the session. Understand that this is likely due to server load on testing site.
Image

First blank and takes a few seconds to load
Image

Only see the grids:
Image

@manjitapandey
Copy link
Author

Hi all, the issue of not loading the basemap has been fixed.

@Pseudorandom-Pseudonym
Copy link

The "Projects to validate" filter does not function as desired. This is the case for both the FastAPI and the current HOT Tasking manager site. Please see the issue I published regarding this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: backend status: testing Does it really work or is it pretending to work? tech-debt 💣
Projects
None yet
Development

No branches or pull requests

8 participants